1494054 - All Payment* webidl interfaces should only be exposed to secure contexts

Status: RESOLVED INVALID

(Core :: DOM: Web Payments, defect)

Description

[Treeherder Bug Filer]

Filed by: mozilla [at] noorenberghe.ca

https://treeherder.mozilla.org/logviewer.html#?job_id=201472818&repo=try

https://queue.taskcluster.net/v1/task/AfD5nezTQQGs8jfH65XC8w/runs/0/artifacts/public/logs/live_backing.log

Comment 1

[Matthew N. [:MattN]]

See dom/tests/mochitest/general/test_interfaces_secureContext.html after enabling with bug 1481971.

Comment 2

[Marcos Caceres [:marcosc]]

Hi Baku... weird thing here. The referenced mochitest is claiming that the various Payment Request API interfaces are showing up in insecure contexts, but the interfaces in the IDL files are clearly marked as `SecureContext` and definitely don't have ` Func="IsChromeOrXBL"` declared on them. 

I've checked in Nightly, and the interfaces don't show up for me in insecure contexts (http://) or in the browser's debug console. Any ideas?

Comment 3

[Andrea Marchesini [:baku]]

(In reply to Marcos Caceres [:marcosc] from comment #2)
> Hi Baku... weird thing here. The referenced mochitest is claiming that the
> various Payment Request API interfaces are showing up in insecure contexts,
> but the interfaces in the IDL files are clearly marked as `SecureContext`
> and definitely don't have ` Func="IsChromeOrXBL"` declared on them. 

White insecure contexts? It seems to me that the test is for secureContexts.

Comment 4

[Marcos Caceres [:marcosc]]

Wait, I’ll try this again. I need to apply the patch from the other bug 🤪

Comment 5

[Matthew N. [:MattN]]

Ah, sorry, I guess I misunderstood the test failure. I guess we just need to update test_interfaces_secureContext.html to add the Payment* interfaces in bug 1494054.

Comment 6

[Matthew N. [:MattN]]

I meant bug 1481971

Comment 7

[Marcos Caceres [:marcosc]]

(In reply to Matthew N. [:MattN] (PM me if requests are blocking you) from comment #5)
> Ah, sorry, I guess I misunderstood the test failure.

Me too. I thought it was appearing in insecure contexts! 

> I guess we just need to
> update test_interfaces_secureContext.html to add the Payment* interfaces in
> bug 1494054.

Ok cool.

Comment 8

[Intermittent Failures Robot]

1 failures in 2773 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:
* try: 1

Platform breakdown:
* windows10-64-qr: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1494054&startday=2018-09-24&endday=2018-09-30&tree=all