149406 - Theme prefpanel - Uninstall button jumps around for long theme names

Status: RESOLVED FIXED

(Core Graveyard :: Skinability, defect)

Description

[ck]

When theme name is too long, like 'orbit 3+1 1.0rc3 0.0.4' preferences form
doesn't resize or truncate name, unistall button is half visible.

Comment 1

[Matthias Versen [:Matti]]

Build ID ?

-> skinability

Comment 2

[ck]

build ID ? it was rc3

Comment 3

[Michael Lefevre]

reporter: can you reproduce this bug with a recent build of mozilla (for
example, 1.2)? if so, please comment again with details. if not, please resolve
this bug as WORKSFORME. thanks.

Comment 4

[ck]

I have prepared a demostration for you fellahs.
Please visit my page
http://www.x.dsl.pipex.com/

Chris

P.S the build ID is 2002101612

Comment 5

[ck]

Just wanted to let you know it's still there.
latest build id is 2003020308

Comment 6

[Joe Infla]

Confirming in 1.3b.  Strangely though, the position of the button varies
depending on what theme was highlighted before selecting the current one.

Steps:
1) Install Skypilot Classic & Pinball themes.
2) In Themes pref panel, highlight themes in the following order, noting how
much text is shown from the Skypilot uninstall button:
   a - Classic
   b - Skypilot
   c - Pinball
   d - Skypilot
   e - (Click empty space) Nothing highlighted

Actual Results:
Both the Skypilot button and the screenshot jump all over the place.  In
particular, by (d) above, nearly half the button is missing, while at (e) the
button is fully visible.

Expected results:
Button & screenshot don't jump around.  

Comment 7

[Joe Infla]

updating to more descriptive summary

Comment 8

[Joe Infla]

*** Bug 149457 has been marked as a duplicate of this bug. ***

Comment 9

[Joe Infla]

*** Bug 160113 has been marked as a duplicate of this bug. ***

Comment 10

[Joe Infla]

Attachment: separate description from title & author

This patch modifies pref-themes.xul to place the theme description in a
separate hbox below the uninstall button.  The left offset of the uninstall
button for a given theme was being affected by the width of the description
field of the previously highlighted theme.  This patch makes it so that only
the title & author fields can directly affect the left offset of the uninstall
button.  

Specifically, the effects of this patch are:
1 - the uninstall button is more resistant to being pushed off-window.	It
takes a longer title or author field than before to cause the bug.
2 - The description field can extend underneath the uninstall button, making
the effects described in bug 149453 and bug 149448 less likely also.
3 - zero visual difference of the theme pref window beside what's described in
#2 above.

This patch doesn't fix the bug, but makes its occurrence much less likely than
before.

Comment 11

[Joe Infla]

Attachment: before & after - two views

The upper case shows the effect of a long description on the theme window
before & after the patch.  The lower case shows how the button behaves in in
step d from comment 6.

BTW, the diff is from current cvs, and I tested in 1.3beta without problems.

Comment 12

[Joe Infla]

Attachment: newpatch - don't remove accesskey

Sorry, missed the accesskey in the last patch.	It's back now.

Comment 13

[[e-mail]]

Comment on attachment 115760 [details] [diff] [review]
newpatch - don't remove accesskey

>+  <hbox>
>+    <vbox flex="1">
>+      <label id="description" flex="1"/>
>     </vbox>
>   </hbox>
This is far to complicated. Just remove the flex="1" from the label, then you
don't need either of the boxes.

Comment 14

[Joe Infla]

Attachment: Neil's simple patch

Right you are.	New patch addressing previous comment.

Comment 15

[jag (Peter Annema)]

Comment on attachment 122963 [details] [diff] [review]
Neil's simple patch

sr=jag

Comment 16

[Asa Dotzler [:asa]]

Comment on attachment 122963 [details] [diff] [review]
Neil's simple patch

a=asa (on behalf of drivers) for checkin to 1.4

Comment 17

[[e-mail]]

Guessing that Joe doesn't have cvs access, so checked fix in.