Closed Bug 1494079 Opened 2 years ago Closed 2 years ago

Clean up some code in ShowProtectedAuthPrompt

Categories

(Core :: Security: PSM, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: mccr8, Assigned: mccr8)

References

Details

Attachments

(1 file)

This function contains a block of code that does a QI from nsProtectedAuthThread to nsIProtectedAuthThread, which isn't needed because a static_cast will do. That lets us remove a null check. There's also some manual ADDREF and RELEASE that can be replaced with a RefPtr.
Comment on attachment 9011964 [details]
Bug 1494079 - Clean up some code in ShowProtectedAuthPrompt

Dana Keeler [:keeler] (she/her) (use needinfo) has approved the revision.
Attachment #9011964 - Flags: review+
Pushed by amccreight@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cf71cf4d1e9f
Clean up some code in ShowProtectedAuthPrompt r=keeler
https://hg.mozilla.org/mozilla-central/rev/cf71cf4d1e9f
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.