1494087 - The "watch" button for a push silently fails if browser notifications have been globally disabled

Status: RESOLVED FIXED

(Tree Management :: Treeherder: Frontend, defect, P1)

Description

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

On https://treeherder.mozilla.org/#/jobs?repo=try&revision=7011899d08b7054340bb2791968f180bc1301cbf&group_state=expanded if I click the "watch" button in the push header, nothing seems to happen. If I look in the web console, I see the following error:
TypeError: this.thNotify is undefined Push.jsx:124:8

Line 124 is: this.thNotify.send('Notification permission denied', 'danger');

I have notification requests disabled globally in Firefox's settings. If I stop blocking them, the notification request rightfully goes through, since line 124 is never hit.

Is this something from the switch to React?

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/4073

Comment 2

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/88e1d1035204ca1db99688507da6eca135ba6347
Bug 1494087 - Make sure thNotify is available in Push.jsx (#4073)

Comment 3

[Ed Morley [:emorley]]

Many thanks :-)