Open
Bug 1494102
Opened 6 years ago
Updated 2 years ago
enhance minimal boolean variant impl for kvstore to add full support for mozStorage
Categories
(Toolkit :: Storage, enhancement, P3)
Toolkit
Storage
Tracking
()
NEW
People
(Reporter: myk, Unassigned)
Details
Bug 1490496 reuses the classes in Variant.h for the kvstore bindings as a common implementation of a simple threadsafe variant for the storage of primitive values only. It also adds a minimal boolean variant implementation to that file for kvstore use cases. Once it lands, we should enhance that implementation to add full boolean variant support for mozStorage.
Updated•6 years ago
|
Priority: -- → P3
Reporter | ||
Comment 1•6 years ago
|
||
Specifically, we should implement asBool conversions from primitive int 0 and 1 as well, since that'd let us clean up some conversions in Places, such as: * https://searchfox.org/mozilla-central/rev/0640ea80fbc8d48f8b197cd363e2535c95a15eb3/toolkit/components/places/SQLFunctions.cpp#564-565 * https://searchfox.org/mozilla-central/rev/0640ea80fbc8d48f8b197cd363e2535c95a15eb3/toolkit/components/places/SQLFunctions.cpp#1057 * https://searchfox.org/mozilla-central/rev/0640ea80fbc8d48f8b197cd363e2535c95a15eb3/toolkit/components/places/nsNavHistory.cpp#3189
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•