1494111 - Remove redundant QI from TestURIMutator

Status: RESOLVED FIXED

(Core :: Networking, enhancement, P5)

Description

[Andrew McCreight [:mccr8]]

This test contains the following code:

   // This test verifies that we can pass nsIURI** to Finalize.
   // We need to use the explicit template because it's actually passing getter_AddRefs
   nsCOMPtr<nsIURI> uri2;
   rv = NS_MutateURI(url2)
          .SetQuery(NS_LITERAL_CSTRING("newquery"))
          .Finalize<nsIURI>(getter_AddRefs(uri2));

The parameterized version of Finalize is not actually needed, because the thing being passed in is already an nsIURI, so the QI is not needed. My patch in bug 1493226 bans trivial QIs, so this needs to be fixed in some way. I'm splitting this out for review from a networking peer because I want to make sure I'm not misunderstanding something here.

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: Bug 1494111 - Remove redundant QI from TestURIMutator

The templated version of Finalize is not needed, because the argument
being passed in is already an nsIURI, so the QI is not needed.

Comment 2

[Honza Bambas (:mayhemer)]

Comment on attachment 9011986 [details]
Bug 1494111 - Remove redundant QI from TestURIMutator

Honza Bambas (:mayhemer) has approved the revision.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b4a6dc2414e1
Remove redundant QI from TestURIMutator r=mayhemer

Comment 4

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/b4a6dc2414e1