Closed Bug 1494111 Opened 2 years ago Closed 2 years ago

Remove redundant QI from TestURIMutator

Categories

(Core :: Networking, enhancement, P5)

enhancement

Tracking

()

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: mccr8, Assigned: mccr8)

References

Details

(Whiteboard: [necko-triaged])

Attachments

(1 file)

This test contains the following code:

   // This test verifies that we can pass nsIURI** to Finalize.
   // We need to use the explicit template because it's actually passing getter_AddRefs
   nsCOMPtr<nsIURI> uri2;
   rv = NS_MutateURI(url2)
          .SetQuery(NS_LITERAL_CSTRING("newquery"))
          .Finalize<nsIURI>(getter_AddRefs(uri2));

The parameterized version of Finalize is not actually needed, because the thing being passed in is already an nsIURI, so the QI is not needed. My patch in bug 1493226 bans trivial QIs, so this needs to be fixed in some way. I'm splitting this out for review from a networking peer because I want to make sure I'm not misunderstanding something here.
The templated version of Finalize is not needed, because the argument
being passed in is already an nsIURI, so the QI is not needed.
Priority: -- → P5
Whiteboard: [necko-triaged]
Comment on attachment 9011986 [details]
Bug 1494111 - Remove redundant QI from TestURIMutator

Honza Bambas (:mayhemer) has approved the revision.
Attachment #9011986 - Flags: review+
Pushed by amccreight@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b4a6dc2414e1
Remove redundant QI from TestURIMutator r=mayhemer
https://hg.mozilla.org/mozilla-central/rev/b4a6dc2414e1
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.