Closed Bug 1494175 Opened 3 years ago Closed 3 years ago

Streamline nsIWebBrowser{,Chrome}.idl.

Categories

(Toolkit :: General, enhancement, P5)

enhancement

Tracking

()

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: n.nethercote, Assigned: n.nethercote)

References

Details

Attachments

(3 files)

They have some unused stuff in them.
Assignee: nobody → n.nethercote
Status: NEW → ASSIGNED
All implementations of these methods fail immediately. This patch removes them,
and replaces their call sites with failures. Code coverage indicates these
locations aren't hit by any of our tests.
Attachment #9012101 - Flags: review?(kyle)
Triage: enhancement, code clean-up
Priority: -- → P5
Attachment #9012099 - Flags: review?(kyle) → review+
Attachment #9012100 - Flags: review?(kyle) → review+
Comment on attachment 9012101 [details] [diff] [review]
Remove unimplemented nsIWebBrowserChrome methods

Review of attachment 9012101 [details] [diff] [review]:
-----------------------------------------------------------------

Wow. Just. Wow. All of the implementations failed. That's wild.
Attachment #9012101 - Flags: review?(kyle) → review+
Pushed by nnethercote@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4e1209a0f188
Remove unused nsIWebBrowser methods and attributes. r=qdot
https://hg.mozilla.org/integration/mozilla-inbound/rev/7a064423a1ad
Remove unused nsIWebBrowserChrome methods and attributes. r=qdot
https://hg.mozilla.org/integration/mozilla-inbound/rev/00de0dfa82f2
Remove unimplemented nsIWebBrowserChrome methods. r=qdot
You need to log in before you can comment on or make changes to this bug.