Closed Bug 1494197 Opened Last year Closed Last year

[wpt-sync] Sync PR 13212 - Simplify "WouldTaintOrigin" concept in media/blink

Categories

(Testing :: web-platform-tests, enhancement, P4)

enhancement

Tracking

(firefox64 fixed)

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: wptsync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 13212 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/13212
Details from upstream follow.

Yutaka Hirano <yhirano@chromium.org> wrote:
>  Simplify "WouldTaintOrigin" concept in media/blink
>  
>  Currently WebMediaPlayer has three predicates:
>   - DidGetOpaqueResponseFromServiceWorker
>   - HasSingleSecurityOrigin
>   - DidPassCORSAccessCheck
>  . These are used to determine whether the response body is available
>  for scripts. They are known to be confusing, and actually
>  MediaElementAudioSourceHandler::WouldTaintOrigin misuses them.
>  
>  This CL merges the three predicates to one, WouldTaintOrigin, to remove
>  the confusion. Now the "response type" concept is available and we
>  don't need a custom CORS check, so this CL removes
>  BaseAudioContext::WouldTaintOrigin. This CL also renames
>  URLData::has_opaque_data_ and its (direct and indirect) data accessors
>  to match the spec.
>  
>  Bug: 849942, 875153
>  Change-Id: I6acf50169d7445c4ff614e80ac606f79ee577d2a
>  
>  Reviewed-on: https://chromium-review.googlesource.com/1238098
>  WPT-Export-Revision: 9c2b9d865154fe421468fbfaf6da57ee5cd9a12c
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Ran 1 tests and 1 subtests
OK     : 1
PASS   : 1
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/620367d865ab
[wpt PR 13212] - Simplify "WouldTaintOrigin" concept in media/blink, a=testonly
https://hg.mozilla.org/mozilla-central/rev/620367d865ab
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.