Closed
Bug 1494197
Opened 7 years ago
Closed 7 years ago
[wpt-sync] Sync PR 13212 - Simplify "WouldTaintOrigin" concept in media/blink
Categories
(Testing :: web-platform-tests, enhancement, P4)
Testing
web-platform-tests
Tracking
(firefox64 fixed)
RESOLVED
FIXED
mozilla64
| Tracking | Status | |
|---|---|---|
| firefox64 | --- | fixed |
People
(Reporter: wpt-sync, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 13212 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/13212
Details from upstream follow.
Yutaka Hirano <yhirano@chromium.org> wrote:
> Simplify "WouldTaintOrigin" concept in media/blink
>
> Currently WebMediaPlayer has three predicates:
> - DidGetOpaqueResponseFromServiceWorker
> - HasSingleSecurityOrigin
> - DidPassCORSAccessCheck
> . These are used to determine whether the response body is available
> for scripts. They are known to be confusing, and actually
> MediaElementAudioSourceHandler::WouldTaintOrigin misuses them.
>
> This CL merges the three predicates to one, WouldTaintOrigin, to remove
> the confusion. Now the "response type" concept is available and we
> don't need a custom CORS check, so this CL removes
> BaseAudioContext::WouldTaintOrigin. This CL also renames
> URLData::has_opaque_data_ and its (direct and indirect) data accessors
> to match the spec.
>
> Bug: 849942, 875153
> Change-Id: I6acf50169d7445c4ff614e80ac606f79ee577d2a
>
> Reviewed-on: https://chromium-review.googlesource.com/1238098
> WPT-Export-Revision: 9c2b9d865154fe421468fbfaf6da57ee5cd9a12c
| Assignee | ||
Updated•7 years ago
|
Whiteboard: [wptsync downstream] → [wptsync downstream error]
| Assignee | ||
Updated•7 years ago
|
Whiteboard: [wptsync downstream error] → [wptsync downstream]
| Assignee | ||
Comment 1•7 years ago
|
||
| Assignee | ||
Comment 2•7 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=7dfd3ec6c28f4f58b84dec0ce18da0f03090ad94
| Assignee | ||
Comment 3•7 years ago
|
||
| Assignee | ||
Comment 4•7 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=c034ce278cc6ae1f76416028ad9d03e8507e0573
| Assignee | ||
Comment 5•7 years ago
|
||
| Assignee | ||
Comment 6•7 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=f5fa6f3578a12ccbd66f60a107b918d01b2fafa1
| Assignee | ||
Comment 7•7 years ago
|
||
| Assignee | ||
Comment 8•7 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=cb22bb3c6af3a3a6e184fe3263ef00c4a68a4501
| Assignee | ||
Comment 9•7 years ago
|
||
Ran 1 tests and 1 subtests
OK : 1
PASS : 1
Comment 10•7 years ago
|
||
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/620367d865ab
[wpt PR 13212] - Simplify "WouldTaintOrigin" concept in media/blink, a=testonly
Comment 11•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in
before you can comment on or make changes to this bug.
Description
•