Closed Bug 1494231 Opened Last year Closed Last year

Update data/element segment encoding to allow for active-segment-with-target-index

Categories

(Core :: Javascript: WebAssembly, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: lth, Assigned: lth)

Details

Attachments

(1 file)

In [1] an extension to the data and element segment encoding was accepted wherein the kind '2' becomes valid in the encoding of data and element sections.  This kind denotes an active segment in the manner of kind '0', but it additionally makes space for an explicit memory/table index to directly follow the kind byte.

For now, the memory/table index must be zero, of course.

This encoding is newly relevant since the reftypes proposal effectively introduces multiple tables.

[1] https://github.com/WebAssembly/bulk-memory-operations/commit/872fcfa4d89b54839b1b8ff852f787b636c071bd#diff-f803f2ddb8f267b3e7b060adcd576abb
Attachment #9012105 - Flags: review?(jseward)
Comment on attachment 9012105 [details] [diff] [review]
bug1494231-active-seg-with-index.patch

Review of attachment 9012105 [details] [diff] [review]:
-----------------------------------------------------------------

Looks fine to me, except that the test cases don't verify that an exception
is thrown for the case where the initialiser-kind-byte is 2 but the memory
index (that immediately follows) is nonzero.  r+ with that fixed.
Attachment #9012105 - Flags: review?(jseward) → review+
https://hg.mozilla.org/mozilla-central/rev/0de3edc61353
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.