Closed Bug 1494232 Opened 6 years ago Closed 3 years ago

[JEXL targeting] addonsInfo.addons does not include userDisabled addons

Categories

(Firefox :: Messaging System, defect, P3)

defect

Tracking

()

RESOLVED WONTFIX
Tracking Status
firefox63 --- wontfix
firefox64 --- affected
firefox65 --- wontfix
firefox66 --- wontfix
firefox67 --- wontfix

People

(Reporter: giorgos, Assigned: andreio)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

addonsInfo.addons does not list user disabled addons.

STR:

 - Open browser console
 - ChromeUtils.defineModuleGetter(this, "ASRouterTargeting",
 "resource://activity-stream/lib/ASRouterTargeting.jsm"); 
 - ASRouterTargeting.Environment.addonsInfo.then(console.log)
 - Installed but user disabled addons do not get listed

Snippets needs this information to target browsers which have addon X
 - installed and enabled
 - installed and disabled
Assignee: nobody → andrei.br92
Iteration: --- → 64.3 (Oct 12)
Priority: -- → P1
Just adding notes from chatting with ddurst about the add-ons/CFR bugs.  stuart coleville also a good source for this.


Ddurst: "if it's like https://searchfox.org/mozilla-central/source/browser/components/newtab/lib/ASRouterTargeting.jsm#127, the issue could be that they're using `getActiveAddons` -- which does exactly that.

If the CFR code is like that (or if that *is* that code), it should be using `getAddonsByTypes` and looking at the addons returned from that."
Blocks: 1432588
Iteration: 64.3 (Oct 12) → 65.1 (Nov 2)
Iteration: 65.1 (Nov 2) → 65.2 (Nov 16)
I'm doing some Snippets 2018Q4 goals housekeeping, related to this bug. 

Could you update us on the status: Will this get implemented in 64? If not, should we expect it in 65?
Flags: needinfo?(tspurway)
this will not be in 64 unless we explicitly ask for uplift, though this will land in 65
Flags: needinfo?(tspurway)
Assignee: andrei.br92 → nobody
Priority: P1 → P3
Iteration: 65.2 (Nov 16) → ---

This is still not working on 65.0b11.

The original request (bug 1431525) is now one year old. Can we get an update whether this is fixed or when will be fixed to plan accordingly?

Thanks!

Flags: needinfo?(tspurway)

i am clearing the priority field so this comes up in next week's triage

Flags: needinfo?(tspurway)
Priority: P3 → --
Iteration: --- → 67.2 - Feb 11 - 24
Priority: -- → P1
Assignee: nobody → andrei.br92
Iteration: 67.2 - Feb 11 - 24 → 68.1 - Mar 18 - 31
Priority: P1 → P2
Priority: P2 → P1
Iteration: 68.1 - Mar 18 - 31 → 68.2 - Apr 1 - 14
Iteration: 68.2 - Apr 1 - 14 → ---
Priority: P1 → P2
Component: Activity Streams: Newtab → Messaging System
Priority: P2 → P3
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: