Closed Bug 1494244 Opened 2 years ago Closed 2 years ago

Remove dead code in and around nsFrameLoader methods

Categories

(Core :: DOM: Core & HTML, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: njn, Assigned: njn)

Details

Attachments

(1 file)

This was found with the help of code coverage results.
I think this is legit, and it passes tests, but I'm not 100% certain.
Attachment #9012102 - Flags: review?(bzbarsky)
Priority: -- → P2
Comment on attachment 9012102 [details] [diff] [review]
Remove dead code in and around nsFrameLoader methods

Some of this looks like landed but not-hooked-up yet work for Fission.  Please check with Nika before removing any of this stuff.
Attachment #9012102 - Flags: review?(bzbarsky) → review?(nika)
Comment on attachment 9012102 [details] [diff] [review]
Remove dead code in and around nsFrameLoader methods

Review of attachment 9012102 [details] [diff] [review]:
-----------------------------------------------------------------

I think this stuff has outlived its usefulness. I was considering using it at one point for process switching loads, but I'm not sure that's worthwhile atm.
Attachment #9012102 - Flags: review?(nika) → review+
Pushed by nnethercote@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fd66515c2152
Remove dead code in and around nsFrameLoader methods. r=nika
https://hg.mozilla.org/mozilla-central/rev/fd66515c2152
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.