1494250 - Disabling suggested searches sometimes ignores enter key

Status: RESOLVED INCOMPLETE

(Firefox :: Address Bar, defect, P5)

Description

[u625005]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:62.0) Gecko/20100101 Firefox/62.0
Build ID: 20180922012926

Steps to reproduce:

1. Set browser.urlbar.suggest.searches to false via about:config to hide the dropdown menu to select search engines

2. Using the unified navigation and search bar, type in a keyword and hit enter


Actual results:

There now seems to be a small time window after entering the last letter of a keyword in which the enter key is ignored. For instance, typing a single letter and immediately pressing enter to execute the search does not seem to work reliably.  Note that I cannot reproduce this behavior when browser.urlbar.suggest.searches is enabled.

While this issue only occurs when typing very fast, personally, I encounter this behavior several times a day.


Expected results:

The search should be executed immediately after hitting enter. Instead, it is sometimes necessary to hit enter twice to execute a search.

Comment 1

[Drew Willcoxon :adw]

I'm not able to reproduce this on either 62 or Nightly, but we do buffer the enter key in some cases and replay it shortly afterward, so it's plausible.  I'd be a little surprised if browser.urlbar.suggest.searches has something to do with it, although I guess it's possible since we don't wait around for search suggestions if it's false.  Is disabling that preference really necessary to reproduce the problem?

Comment 2

[u625005]

It's the only way I can reproduce the issue, yes, and I've been testing it several times. As I said, it's a subtle thing since you have to hit enter almost instantly after typing the last letter of the search query. That being said, I just tried to reproduce the issue on another machine (same distro, same firefox version), and the problem does not occur there either. I'm not quite sure what to make of all this, but I think I'll just re-enable the option again and be done with it. In general, it's a very low-impact issue. I just opened the ticket in case there was an easy obvious answer/solution to it. Thanks for looking into it.

Comment 3

[Drew Willcoxon :adw]

Thanks for replying and for filing the bug.  I don't doubt that you saw a problem, and it's entirely plausible that it seems to happen at random.

Comment 4

[Marco Bonardo [:mak]]

Unfortunately this is not actionable, feel free to reopen if it's still happening