1494312 - Make mtransport API entirely async

Status: RESOLVED FIXED

(Core :: WebRTC: Networking, enhancement, P2)

Description

[Byron Campen [:bwc]]

There are a few places where the mtransport API has a function that returns stuff when called on STS (eg; GetDefaultCandidates). This will need to be refactored to be async, since we're going to be serving this API vie IPC.

Comment 1

[Byron Campen [:bwc]]

I think we'll end up using some cacheing for transport state, and keep MediaTransportHandler::GetState, but we need to make stats calls async, and also plumb a way for errors to get back in an async manner.

Comment 2

[Byron Campen [:bwc]]

I will also remove nsresult returns that don't actually do anything besides trigger some logging on the signaling side of things.

Comment 3

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1f26601e6e1f36a7713fe2c22d4a5e88f35c4a2e

Comment 4

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=360fe6ffbfe8b04d5dafbfa78ebfcd177fd6c16b

Comment 5

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c791a98f9695b24b5fd4bc514e7a327d50b33571

Comment 6

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f0e376d632841be2ab58f4a73928b8772bbbd693

Comment 7

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0b845a5caf2009af41d8ae88a8702794fd409e4b

Comment 8

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0ad6f7092bcb6791d133ddd6eca153c53450db2b

Comment 9

[Byron Campen [:bwc]]

Attachment: Bug 1494312 - Part 1: Remove unused nsresult returns from MediaTransportHandler.

Comment 10

[Byron Campen [:bwc]]

Attachment: Bug 1494312 - Part 2: Make the internal PC stats API based on MozPromise.

Comment 11

[Byron Campen [:bwc]]

Attachment: Bug 1494312 - Part 3: Expose RLog stuff via MediaTransportHandler.

Comment 12

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0362a1d5d91bbed16224f792d11f0ab05116655f

Comment 13

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4880fad1ae21221eff710a6d093d59d21681f305

Comment 14

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ad12a317d7d499a8cdf60c625e89148d687a3de1

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4185df9ce3e1
Part 1: Remove unused nsresult returns from MediaTransportHandler. r=mjf
https://hg.mozilla.org/integration/autoland/rev/ca59ca222bd5
Part 2: Make the internal PC stats API based on MozPromise. r=mjf,mayhemer
https://hg.mozilla.org/integration/autoland/rev/f28667d0d2cb
Part 3: Expose RLog stuff via MediaTransportHandler. r=mjf

Comment 17

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/4185df9ce3e1
https://hg.mozilla.org/mozilla-central/rev/ca59ca222bd5
https://hg.mozilla.org/mozilla-central/rev/f28667d0d2cb