1494321 - Stop doing wasteful pre/post-effects work for frames with just a clip-path or mask applied

Status: RESOLVED FIXED

(Core :: SVG, enhancement, P3)

Description

[Jonathan Watt [:jwatt]]

The 'clip-path' and 'mask' properties do not affect the overflow of frames. There is no need to "calculate" the "post"-effects overflow, or store the "pre"-clip-path/mask overflow, for frame that don't have a "filter" applied.

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: Bug 1494321. Stop doing wasteful pre/post-effects work for frames with just a clip-path or mask applied. r?miko

Comment 2

[Miko Mynttinen]

Comment on attachment 9012218 [details]
Bug 1494321. Stop doing wasteful pre/post-effects work for frames with just a clip-path or mask applied. r?miko

Miko Mynttinen [:miko] has approved the revision.

Comment 3

[Jonathan Watt [:jwatt]]

Attachment: Bug 1494321 p1. Fix bug in PreEffectsVisualOverflowCollector::GetPreEffectsVisualOverflowRect. r?mattwoodrow

Comment 4

[Jonathan Watt [:jwatt]]

Turns out part 2 exposes a pre-existing bug in PreEffectsVisualOverflowCollector::GetPreEffectsVisualOverflowRect, hence the need for part 1.

Comment 5

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 9012349 [details]
Bug 1494321 p1. Fix bug in PreEffectsVisualOverflowCollector::GetPreEffectsVisualOverflowRect. r?mattwoodrow

Matt Woodrow (:mattwoodrow) has approved the revision.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/36f1de5b94d0
p1. Fix bug in PreEffectsVisualOverflowCollector::GetPreEffectsVisualOverflowRect. r=mattwoodrow
https://hg.mozilla.org/integration/mozilla-inbound/rev/49e9981519df
p2. Stop doing wasteful pre/post-effects work for frames with just a clip-path or mask applied. r=miko

Comment 7

[Jonathan Watt [:jwatt]]

I should note that - as discussed with Miko on IRC - in part 2 I also removed the addition of nsChangeHint_UpdateOverflow for clip-path and mask changes. This code was only necessary because of the bug that was fixed in part 1.

That use of that change hint was originally added to nsStyleSVGReset::CalcDifference in bug 1030604:
https://hg.mozilla.org/mozilla-central/rev/8dd8407fd66b#l4.24

And then copied over to nsStyleImageLayers::Layer::CalcDifference in bug 686281:
https://hg.mozilla.org/mozilla-central/rev/42e90ed0f40e#l3.114

Comment 8

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/36f1de5b94d0
https://hg.mozilla.org/mozilla-central/rev/49e9981519df