1494330 - Combine nsComboboxControlFrame::mDropdownFrame and mListControlFrame

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, enhancement, P5)

Description

[Neil Deakin]

They refer to the same frame.

Also, remove usages of 'static_cast<nsListControlFrame*>(mDropdownFrame)'

Comment 1

[Ting-Yu Lin [:TYLin] (UTC-8)]

Attachment: Bug 1494330 Part 1 - Make NS_NewListControlFrame() return nsListControlFrame*.

Also, add nsListControlFrame to the forward declaration list in
nsHTMLParts, and sort them alphabetically.

Comment 2

[Ting-Yu Lin [:TYLin] (UTC-8)]

Attachment: Bug 1494330 Part 2 - Change nsComboboxControlFrame::mDropdownFrame's type to nsListControlFrame*.

This eliminates a lot of down casting from nsIFrame* to nsListControlFrame*.

Make SetDropDown() accepts nsListControlFrame* because
nsCSSFrameConstructor already passes the derived type in.

We'll replace mListControlFrame with mDropdownFrame in the next part.

Depends on D119205

Comment 3

[Ting-Yu Lin [:TYLin] (UTC-8)]

Attachment: Bug 1494330 Part 3 - Remove nsComboboxControlFrame::mListControlFrame.

mListControlFrame is the same as mDropdownFrame. See SetDropDown().

Depends on D119206

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cdae5012ffbd
Part 1 - Make NS_NewListControlFrame() return nsListControlFrame*. r=layout-reviewers,boris
https://hg.mozilla.org/integration/autoland/rev/dd89d3803b20
Part 2 - Change nsComboboxControlFrame::mDropdownFrame's type to nsListControlFrame*. r=layout-reviewers,boris
https://hg.mozilla.org/integration/autoland/rev/6ff478f9cce9
Part 3 - Remove nsComboboxControlFrame::mListControlFrame. r=layout-reviewers,boris

Comment 5

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/cdae5012ffbd
https://hg.mozilla.org/mozilla-central/rev/dd89d3803b20
https://hg.mozilla.org/mozilla-central/rev/6ff478f9cce9