Closed Bug 1494330 Opened 3 years ago Closed 4 months ago

Combine nsComboboxControlFrame::mDropdownFrame and mListControlFrame

Categories

(Core :: Layout: Form Controls, enhancement, P5)

enhancement

Tracking

()

RESOLVED FIXED
91 Branch
Tracking Status
firefox91 --- fixed

People

(Reporter: enndeakin, Assigned: TYLin)

Details

Attachments

(3 files)

They refer to the same frame.

Also, remove usages of 'static_cast<nsListControlFrame*>(mDropdownFrame)'

Also, add nsListControlFrame to the forward declaration list in
nsHTMLParts, and sort them alphabetically.

This eliminates a lot of down casting from nsIFrame* to nsListControlFrame*.

Make SetDropDown() accepts nsListControlFrame* because
nsCSSFrameConstructor already passes the derived type in.

We'll replace mListControlFrame with mDropdownFrame in the next part.

Depends on D119205

mListControlFrame is the same as mDropdownFrame. See SetDropDown().

Depends on D119206

Assignee: nobody → aethanyc
Status: NEW → ASSIGNED
Pushed by aethanyc@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/cdae5012ffbd
Part 1 - Make NS_NewListControlFrame() return nsListControlFrame*. r=layout-reviewers,boris
https://hg.mozilla.org/integration/autoland/rev/dd89d3803b20
Part 2 - Change nsComboboxControlFrame::mDropdownFrame's type to nsListControlFrame*. r=layout-reviewers,boris
https://hg.mozilla.org/integration/autoland/rev/6ff478f9cce9
Part 3 - Remove nsComboboxControlFrame::mListControlFrame. r=layout-reviewers,boris
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
You need to log in before you can comment on or make changes to this bug.