46 bytes, text/x-phabricator-request
|Details | Review|
I attempted to switch browser_urlbarTrimURLs.js to using value instead of textValue but the behavior is different, so I had to revert this. textValue is used only in tests it seems, so I'm not quite sure whether we need to implement it or somehow change the tests.
So given bug 1500080, I think implementing the getter makes sense. As for the setter: In the old world, this primarily existed for the autocomplete binding to set the input value when selecting a result. That's not how we want this API to work going forward.
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Summary: Figure out urlbar tests' dependency on the textValue property → Implement UrlbarInput::textValue getter
Created attachment 9019334 [details] Bug 1494334 - Implement UrlbarInput::textValue getter. r?standard8 Depends on D9505
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/bc350062ad1b Implement UrlbarInput::textValue getter. r=Standard8
Status: ASSIGNED → RESOLVED
Last Resolved: 27 days ago
status-firefox65: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
You need to log in before you can comment on or make changes to this bug.