Implement UrlbarInput::textValue getter

RESOLVED FIXED in Firefox 65

Status

()

P2
normal
RESOLVED FIXED
2 months ago
25 days ago

People

(Reporter: dao, Assigned: dao)

Tracking

(Blocks: 1 bug)

Trunk
Firefox 65
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox65 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 months ago
I attempted to switch browser_urlbarTrimURLs.js to using value instead of textValue but the behavior is different, so I had to revert this. textValue is used only in tests it seems, so I'm not quite sure whether we need to implement it or somehow change the tests.
(Assignee)

Updated

a month ago
Depends on: 1500080
(Assignee)

Comment 1

27 days ago
So given bug 1500080, I think implementing the getter makes sense. As for the setter: In the old world, this primarily existed for the autocomplete binding to set the input value when selecting a result. That's not how we want this API to work going forward.
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Summary: Figure out urlbar tests' dependency on the textValue property → Implement UrlbarInput::textValue getter
(Assignee)

Comment 2

27 days ago
Created attachment 9019334 [details]
Bug 1494334 - Implement UrlbarInput::textValue getter. r?standard8

Depends on D9505
(Assignee)

Updated

27 days ago
See Also: → bug 1501270

Comment 3

27 days ago
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bc350062ad1b
Implement UrlbarInput::textValue getter. r=Standard8

Comment 4

27 days ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/bc350062ad1b
Status: ASSIGNED → RESOLVED
Last Resolved: 27 days ago
status-firefox65: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
(Assignee)

Updated

26 days ago
See Also: → bug 1501624
(Assignee)

Updated

25 days ago
Blocks: 1501996
You need to log in before you can comment on or make changes to this bug.