Closed
Bug 1494334
Opened 6 years ago
Closed 6 years ago
Implement UrlbarInput::textValue getter
Categories
(Firefox :: Address Bar, task, P2)
Firefox
Address Bar
Tracking
()
RESOLVED
FIXED
Firefox 65
| Tracking | Status | |
|---|---|---|
| firefox65 | --- | fixed |
People
(Reporter: dao, Assigned: dao)
References
Details
Attachments
(1 file)
I attempted to switch browser_urlbarTrimURLs.js to using value instead of textValue but the behavior is different, so I had to revert this. textValue is used only in tests it seems, so I'm not quite sure whether we need to implement it or somehow change the tests.
|
Assignee | |
Comment 1•6 years ago
|
||
So given bug 1500080, I think implementing the getter makes sense. As for the setter: In the old world, this primarily existed for the autocomplete binding to set the input value when selecting a result. That's not how we want this API to work going forward.
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Summary: Figure out urlbar tests' dependency on the textValue property → Implement UrlbarInput::textValue getter
|
|
Assignee | |
Comment 2•6 years ago
|
||
Depends on D9505
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bc350062ad1b
Implement UrlbarInput::textValue getter. r=Standard8
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox65:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
|
|
Assignee | |
Updated•6 years ago
|
Type: enhancement → task
You need to log in
before you can comment on or make changes to this bug.
Description
•