Closed Bug 1494334 Opened 2 years ago Closed 2 years ago

Implement UrlbarInput::textValue getter

Categories

(Firefox :: Address Bar, task, P2)

task

Tracking

()

RESOLVED FIXED
Firefox 65
Tracking Status
firefox65 --- fixed

People

(Reporter: dao, Assigned: dao)

References

Details

Attachments

(1 file)

I attempted to switch browser_urlbarTrimURLs.js to using value instead of textValue but the behavior is different, so I had to revert this. textValue is used only in tests it seems, so I'm not quite sure whether we need to implement it or somehow change the tests.
Depends on: 1500080
So given bug 1500080, I think implementing the getter makes sense. As for the setter: In the old world, this primarily existed for the autocomplete binding to set the input value when selecting a result. That's not how we want this API to work going forward.
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Summary: Figure out urlbar tests' dependency on the textValue property → Implement UrlbarInput::textValue getter
See Also: → 1501270
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bc350062ad1b
Implement UrlbarInput::textValue getter. r=Standard8
https://hg.mozilla.org/mozilla-central/rev/bc350062ad1b
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
See Also: → 1501624
Blocks: 1501996
Type: enhancement → task
You need to log in before you can comment on or make changes to this bug.