Open Bug 1494340 Opened 6 years ago Updated 2 years ago

Remove pref dom.payments.request.user_interaction_required setting when running web-platform tests

Categories

(Core :: DOM: Web Payments, enhancement, P2)

enhancement

Tracking

()

People

(Reporter: edenchuang, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [webpayments-wpt])

We failed some payment-request web-platform tests when pref dom.payments.request.user_interaction_required is true.
Priority: -- → P2
This may be okay for the short term but it seems like that would mean we're not testing the spec requirements (it required user interaction). It would be better to fix the tests to support a click with user interaction (probably though a non-web-facing API). I guess as long as we leave tests specifically for user interaction working properly then the rest of them don't necessarily need to test the activation behaviour.
Agree. If "dom.payments.request.user_interaction_required" is used anywhere, that's a (temporary) bug. But definitely shouldn't have that pref interacting with any WPT tests.
I would like take Marcos' suggestion on bug 1481295 comment 10, set them as expected: FAIL.

I also agree that tests should be updated with triggering the PaymentRequest.show() by trusted click event or others.

BTW, I also found that these tests fail on Chrome 69.
Whiteboard: [webpayments-wpt]
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.