Closed Bug 1494362 Opened 6 years ago Closed 6 years ago

[wpt-sync] Sync PR 13226 - [css-grid] Properly align items next to collapsed tracks with gutters

Categories

(Testing :: web-platform-tests, enhancement, P4)

Product:
Testing
Component:
web-platform-tests
Type:
enhancement

Tracking

(firefox64 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla64
Tracking Flags:
Tracking Status
firefox64 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream]) 

Sync web-platform-tests PR 13226 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/13226
Details from upstream follow.

Oriol Brufau <obrufau@igalia.com> wrote:
>  [css-grid] Properly align items next to collapsed tracks with gutters
>  
>  GridAreaPositionForInFlowChild could return a wrong end position for
>  grid items adjacent to a collapsed track, because it didn't take into
>  account that gutters collapse in that case. Therefore, "center" or
>  "end" alignments displayed the item at the wrong position.
>  
>  BUG=801881
>  
>  TEST=external/wpt/css/css-grid/alignment/grid-gutters-013.html
>  
>  Change-Id: I8223f102e3fd581ab0a2d6f23d18c188e23807c7
>  Reviewed-on: https://chromium-review.googlesource.com/1245727
>  WPT-Export-Revision: cc58bdff26d92913d8449cb20d2e1cb4da25657b
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Ran 1 tests
PASS   : 1
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7266f1e665b4
[wpt PR 13226] - [css-grid] Properly align items next to collapsed tracks with gutters, a=testonly
https://hg.mozilla.org/mozilla-central/rev/7266f1e665b4
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox64: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.