Closed Bug 14944 Opened 21 years ago Closed 21 years ago

{css-moz} -moz-rounded-corners and uneven border-styles

Categories

(Core :: Layout, defect, P3, trivial)

x86
Windows 98
defect

Tracking

()

VERIFIED FIXED

People

(Reporter: ian, Assigned: dcone)

References

()

Details

(Keywords: css-moz)

If border-style is not the same all the way around, eg:
   div { border-style: none solid none solid; -moz-border-radius: 5em; }
...then the -moz-border-radius drawing code goes all weird!

Some examples of what doesn't work are on this page:
   http://www.bath.ac.uk/%7Epy8ieh/internet/projects/mozilla/border-radius.html
Status: NEW → ASSIGNED
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Fixed... the support code did a return when it encountered the first "none"
border style.. so the rest were not being drawn.
QA Contact: petersen → chrisd
Whiteboard: 11/16: Clarification requested from reporter
Ian - what is the anticipated result? Can you look at this and see if you agree
that it's fixed? Thanks.
QA Contact: chrisd → py8ieh=bugzilla
Whiteboard: 11/16: Clarification requested from reporter → (py8ieh:will verify)
Chris: I'll take over QAC and check it tonight. Feel free to change it back if
you want...
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Reopening.

If the top side is not there (or very thin) then the other sides are not drawn
at the full thickness. This is because of the line which says:

   if (aBorThick.top<aTwipsPerPixel) { ...

...in nsCSSRendering::RenderSide (around line 2497 of nsCSSRendering.cpp).
That routine is used for all the sides (see PaintRoundedBorder in the same
file, around line 2350) but that line only checks the thickness of the top
line, not the line being drawn at the time.

See this test case:
   http://www.bath.ac.uk/%7Epy8ieh/internet/projects/mozilla/border-radius.html
If you use VIEWER to look at it, then change to an alternate stylesheet to see
that the problem also occurs when the thickness is very small (as well as when
the top line is literally not present).
Status: REOPENED → RESOLVED
Closed: 21 years ago21 years ago
Resolution: --- → FIXED
I now check for the side being rendered and check that thickness before
rendering... Thanks Again!!!
Status: RESOLVED → VERIFIED
Whiteboard: (py8ieh:will verify)
Yup, works fine.
Summary: {moz-css} -moz-rounded-corners and uneven border-styles → {css-moz} -moz-rounded-corners and uneven border-styles
Keywords: css-moz
You need to log in before you can comment on or make changes to this bug.