Closed Bug 1494486 Opened Last year Closed Last year

Add tests for GV pop-up blocking API

Categories

(GeckoView :: General, enhancement, P1)

All
Android
enhancement

Tracking

(firefox63 fixed, firefox64 fixed)

RESOLVED FIXED
mozilla64
Tracking Status
firefox63 --- fixed
firefox64 --- fixed

People

(Reporter: droeh, Assigned: droeh)

References

Details

Attachments

(1 file)

No description provided.
Adds basic testing for popup blocking, plus a bug fix that testing uncovered.
Attachment #9013365 - Flags: review?(snorp)
Comment on attachment 9013365 [details] [diff] [review]
Add testing for popup blocking

Review of attachment 9013365 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm, and it already found a bug!
Attachment #9013365 - Flags: review?(snorp) → review+
Pushed by droeh@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/59dc22658d45
Add testing for PromptDelegate.onPopupRequest. r=snorp
https://hg.mozilla.org/mozilla-central/rev/59dc22658d45
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
Comment on attachment 9013365 [details] [diff] [review]
Add testing for popup blocking

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: Bug 1481296

User impact if declined: There will be no automated testing for the GeckoView popup blocking API.

Is this code covered by automated tests?: Yes

Has the fix been verified in Nightly?: No

Needs manual test from QE?: No

If yes, steps to reproduce: 

List of other uplifts needed: Bug 1481296

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): Adding tests is pretty low risk by definition.

String changes made/needed:
Attachment #9013365 - Flags: approval-mozilla-beta?
Comment on attachment 9013365 [details] [diff] [review]
Add testing for popup blocking

Uplift approved for 63 beta 12, thanks.
Attachment #9013365 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Product: Firefox for Android → GeckoView
Target Milestone: Firefox 64 → mozilla64
You need to log in before you can comment on or make changes to this bug.