Closed
Bug 1494527
Opened 7 years ago
Closed 7 years ago
Testcase doesn't override Promise[@@species] properly
Categories
(Core :: JavaScript Engine, enhancement, P3)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla64
| Tracking | Status | |
|---|---|---|
| firefox64 | --- | fixed |
People
(Reporter: arai, Assigned: arai)
Details
Attachments
(1 file)
|
1.94 KB,
patch
|
till
:
review+
|
Details | Diff | Splinter Review |
https://searchfox.org/mozilla-central/source/js/src/tests/non262/Promise/enqueue-promise-reactions.js#15
https://searchfox.org/mozilla-central/source/js/src/tests/non262/Promise/get-wait-for-all-promise.js#16
Promise[@@species] is getter, so we should use Object.defineProperty instead
|
Assignee | |
Comment 1•7 years ago
|
||
Attachment #9012473 -
Flags: review?(till)
|
||
Comment 2•7 years ago
|
||
Comment on attachment 9012473 [details] [diff] [review]
Fix testcases to properly override Promise[@@species].
Review of attachment 9012473 [details] [diff] [review]:
-----------------------------------------------------------------
good catch!
Attachment #9012473 -
Flags: review?(till) → review+
|
|
Assignee | |
Comment 3•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/20599af52f6d4372438000d146d008dbe09ed5c4
Bug 1494527 - Fix testcases to properly override Promise[@@species]. r=till
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in
before you can comment on or make changes to this bug.
Description
•