1494598 - Documentation page of about:policies should save the users page position when leaving the section

Status: VERIFIED FIXED

(Firefox :: Enterprise Policies, enhancement, P4)

Description

[Vlad Lucaci, Thunderbird QA (:vlucaci)]

Attachment: Policies Documentation Highlight 2018-09-27 11-23.gif

[Affected versions]:
Firefox 63.0b9 
Firefox 64.0a1 

[Affected platforms]:
Windows 10 64bit.
Ubuntu 16.04 64bit.
macOS 10.13.6

[Preconditions]:
Have the Json file in distribution folder with at least several policies activated.

[Steps to reproduce]:
1. Launch Firefox.
2. Access the about:policies#active page.
3. Go to documentation section.
4. Scroll near the end of the section and click on any parameter to drop down the policy schema information about it.
5. Leave the section (ex: go to Errors or Active)
6.Return to Documentation section.

[Expected result]:
The Documentation section should save the position in which the user has dropped down a policy schematic information and upon returning to the section, it should automatically scroll to the last saved position.

[Actual result]:
Upon returning to the Documentation section, user is left at the top of the list section, making him scroll down in order to return to his last open parameter schematic.

[Notes]:

For further information regarding this issue please observe the attached screenshot GIF.

Please treat this issue as a quality of life improvement. 
It would greatly benefit the users upon searching for faulty errors in Errors section, and comparing them with the explanations if ut from Documentation section , without scrolling and searching the entire area until reaching the desired parameter.

Comment 1

[Ferenc Nagy]

I would like to fix this bug, please assign it to me

Comment 2

[Ferenc Nagy]

Attachment: Bug 1494598 - Implemented scroll restoration on about:policies page r=Felipe

Comment 3

[Ferenc Nagy]

Attachment: Bug 1494598 - Implemented scroll restoration on about:policies page r=Felipe

Comment 4

[Ferenc Nagy]

Fixed the code according to the review comments :)

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/58cd47fe1774
Restore scroll position in about:policies when navigating between sections. r=felipe

Comment 6

[Cristina Coroiu [:ccoroiu]]

Backed out 2 changesets (bug 1497928, bug 1494598) for browser-chrome failures at browser/components/enterprisepolicies/tests/browser/browser_policies_macosparser_unflatten.js 

Backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/afab7f523f072f350733bc3e5ce96a0e76663cf1

Failure push: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=58cd47fe1774e23092d636e32c6afd867fa7fd47

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=217765293&repo=mozilla-inbound&lineNumber=3138

task 2018-12-18T21:12:40.819Z] 21:12:40     INFO - TEST-START | browser/components/enterprisepolicies/tests/browser/browser_policies_macosparser_unflatten.js
[task 2018-12-18T21:12:40.827Z] 21:12:40     INFO - TEST-INFO | started process screentopng
[task 2018-12-18T21:12:41.683Z] 21:12:41     INFO - TEST-INFO | screentopng: exit 0
[task 2018-12-18T21:12:41.683Z] 21:12:41     INFO - TEST-UNEXPECTED-FAIL | browser/components/enterprisepolicies/tests/browser/browser_policies_macosparser_unflatten.js | Exception thrown - [Exception... "File error: Not found"  nsresult: "0x80520012 (NS_ERROR_FILE_NOT_FOUND)"  location: "JS frame :: chrome://mochitests/content/browser/browser/components/enterprisepolicies/tests/browser/browser_policies_macosparser_unflatten.js :: <TOP_LEVEL> :: line 6"  data: no]

Comment 7

[:Felipe Gomes (needinfo for replies!)]

The failure was from the other bug that landed together, see bug 1497928 comment 14

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/08a7274ecb87
Restore scroll position in about:policies when navigating between sections. r=felipe

Comment 9

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/08a7274ecb87

Comment 10

[Mohammad Maruf Rahman]

I have reproduced this bug with Nightly 64.0a1 (2018-09-27) in Windows 10, 64 Bit. This bug's fix is verified with latest Nightly!

Build ID : 20190120213632
User Agent : Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:66.0) Gecko/20100101 Firefox/66.0

Comment 11

[Camelia Badau [:cbadau], Desktop Test Engineering]

Marking VERIFIED FIXED based on previous comment.