marionette.log.level coerced into string rather than Pref type

RESOLVED FIXED in Firefox 64

Status

defect
P1
normal
RESOLVED FIXED
9 months ago
8 months ago

People

(Reporter: ato, Assigned: ato)

Tracking

({regression})

Trunk
mozilla64
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox-esr60 unaffected, firefox62 unaffected, firefox63 wontfix, firefox64 fixed)

Details

()

Attachments

(5 attachments)

Assignee

Description

9 months ago
The patch https://hg.mozilla.org/mozilla-central/rev/c1df1c2e46f6
contained a faulty rebase where the coercion of logging::max_level()
changed from the Pref type to a string.

The string representation of geckodriver::logging::Level is given
in upper-case, e.g. "INFO", and the Pref representation is given
as "Info" to be compatible with managing the log level from Log.jsm
in Gecko.

This inadvertently caused
https://github.com/web-platform-tests/wpt/issues/12166 to reappear
in almost the same way: before the problem was that Marionette’s
frame script always included all log level entries.  This was fixed
with https://bugzilla.mozilla.org/show_bug.cgi?id=1482829, but then
https://bugzilla.mozilla.org/show_bug.cgi?id=1396821 broke it so
that log entries also from chrome space appeared.

Additionally there was a problem in my patch with the backwards
compatibility fallback in
https://bugzilla.mozilla.org/show_bug.cgi?id=1482829 that caused
"INFO" not to ignore the casing of the marionette.log.level preference
input.  Fixing this is tracked in
https://bugzilla.mozilla.org/show_bug.cgi?id=1494611.
Assignee

Comment 1

9 months ago
PrefValue implements From<&'static str>, and this makes the calling
code slightly nicer to look at.
Assignee

Comment 2

9 months ago
Done automatically by running MarionetteHandler through rustfmt(1).

Depends on D7074
Assignee

Comment 3

9 months ago
mozprofile gives us an error and we can forward it to the user so
we know what the underlying reason is for not being able to write
the Firefox profile.

Depends on D7075
Assignee

Comment 5

9 months ago
The patch c1df1c2e46f6 contained a faulty rebase where the coercion
of logging::max_level() changed from the Pref type to a string.

The string representation of geckodriver::logging::Level is given
in upper-case, e.g. "INFO", and the Pref representation is given as
"Info" to be compatible with managing the log level from Log.jsm in Gecko.

This inadvertently caused
https://github.com/web-platform-tests/wpt/issues/12166 to reappear
in almost the same way: before the problem was that Marionette’s
frame script always included all log level entries.  This was fixed
with https://bugzilla.mozilla.org/show_bug.cgi?1482829, but then
https://bugzilla.mozilla.org/show_bug.cgi?id=1396821 broke it so
that log entries also from chrome space appeared.

Depends on D7077
Assignee

Updated

9 months ago
Assignee: nobody → ato
Status: NEW → ASSIGNED
Priority: -- → P1
Comment on attachment 9012560 [details]
bug 1494613: geckodriver: remove unnecessary owned string conversion

Henrik Skupin (:whimboo) has approved the revision.
Attachment #9012560 - Flags: review+
Comment on attachment 9012561 [details]
bug 1494613: geckodriver: drop try!() macro from MarionetteHandler

Henrik Skupin (:whimboo) has approved the revision.
Attachment #9012561 - Flags: review+
Comment on attachment 9012562 [details]
bug 1494613: geckodriver: log reason for not being able to write profile

Henrik Skupin (:whimboo) has approved the revision.
Attachment #9012562 - Flags: review+
Comment on attachment 9012563 [details]
bug 1494613: mozprofile: add docs for Pref::new and ::new_sticky

Henrik Skupin (:whimboo) has approved the revision.
Attachment #9012563 - Flags: review+
Comment on attachment 9012564 [details]
bug 1494613: geckodriver: convert logging::Level to Pref

Henrik Skupin (:whimboo) has approved the revision.
Attachment #9012564 - Flags: review+

Comment 12

9 months ago
Pushed by atolfsen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/729d8f3e1341
geckodriver: remove unnecessary owned string conversion r=whimboo
https://hg.mozilla.org/integration/autoland/rev/8d26a58f754e
geckodriver: drop try!() macro from MarionetteHandler r=whimboo
https://hg.mozilla.org/integration/autoland/rev/457da8a172be
geckodriver: log reason for not being able to write profile r=whimboo
https://hg.mozilla.org/integration/autoland/rev/f9f4e7c55d61
mozprofile: add docs for Pref::new and ::new_sticky r=whimboo
https://hg.mozilla.org/integration/autoland/rev/09e9cefc19ca
geckodriver: convert logging::Level to Pref r=whimboo
Backout link: https://hg.mozilla.org/integration/autoland/rev/af12b0d1495408ede4ddadd92835763168ebc534

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed,busted,exception&revision=09e9cefc19ca63fe9e6d78133d45a05b70285cdc

Log link: https://treeherder.mozilla.org/logviewer.html#?job_id=201953828&repo=autoland&lineNumber=45326

Log snippet: 

[task 2018-09-27T14:02:32.590Z] 14:02:32     INFO - test response::tests::test_json_window_rect_response ... ok
[task 2018-09-27T14:02:32.590Z] 14:02:32     INFO - test result: ok. 174 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out
[task 2018-09-27T14:02:32.590Z] 14:02:32     INFO -    Doc-tests webdriver
[task 2018-09-27T14:02:32.592Z] 14:02:32     INFO -      Running `/builds/worker/workspace/build/src/rustc/bin/rustdoc --test /builds/worker/workspace/build/src/testing/webdriver/src/lib.rs --crate-name webdriver -L dependency=/builds/worker/workspace/build/src/obj-firefox/testing/geckodriver/./x86_64-unknown-linux-gnu/debug/deps -L native=/builds/worker/workspace/build/src/obj-firefox/testing/geckodriver/./x86_64-unknown-linux-gnu/debug/build/bzip2-sys-fa2c502c56a85589/out -L dependency=/builds/worker/workspace/build/src/obj-firefox/testing/geckodriver/./debug/deps --extern base64=/builds/worker/workspace/build/src/obj-firefox/testing/geckodriver/./x86_64-unknown-linux-gnu/debug/deps/libbase64-2ffab77575ee7806.rlib --extern cookie=/builds/worker/workspace/build/src/obj-firefox/testing/geckodriver/./x86_64-unknown-linux-gnu/debug/deps/libcookie-250b0432b1d5bb48.rlib --extern futures=/builds/worker/workspace/build/src/obj-firefox/testing/geckodriver/./x86_64-unknown-linux-gnu/debug/deps/libfutures-932f66aaf9cc0d39.rlib --extern http=/builds/worker/workspace/build/src/obj-firefox/testing/geckodriver/./x86_64-unknown-linux-gnu/debug/deps/libhttp-d8b6cb0b89e14ac6.rlib --extern hyper=/builds/worker/workspace/build/src/obj-firefox/testing/geckodriver/./x86_64-unknown-linux-gnu/debug/deps/libhyper-91010bb7525c43b6.rlib --extern lazy_static=/builds/worker/workspace/build/src/obj-firefox/testing/geckodriver/./x86_64-unknown-linux-gnu/debug/deps/liblazy_static-01911f712b43e365.rlib --extern log=/builds/worker/workspace/build/src/obj-firefox/testing/geckodriver/./x86_64-unknown-linux-gnu/debug/deps/liblog-c6b1d73daba0b492.rlib --extern regex=/builds/worker/workspace/build/src/obj-firefox/testing/geckodriver/./x86_64-unknown-linux-gnu/debug/deps/libregex-136dd60c9245c20e.rlib --extern serde=/builds/worker/workspace/build/src/obj-firefox/testing/geckodriver/./x86_64-unknown-linux-gnu/debug/deps/libserde-cf79968d6f917923.rlib --extern serde_derive=/builds/worker/workspace/build/src/obj-firefox/testing/geckodriver/./debug/deps/libserde_derive-72c242c3410315b0.so --extern serde_json=/builds/worker/workspace/build/src/obj-firefox/testing/geckodriver/./x86_64-unknown-linux-gnu/debug/deps/libserde_json-aec20e2bf1cae0b7.rlib --extern time=/builds/worker/workspace/build/src/obj-firefox/testing/geckodriver/./x86_64-unknown-linux-gnu/debug/deps/libtime-ef7e5cb3cc7eca8a.rlib --extern tokio=/builds/worker/workspace/build/src/obj-firefox/testing/geckodriver/./x86_64-unknown-linux-gnu/debug/deps/libtokio-077144bc2b3858f4.rlib --extern unicode_segmentation=/builds/worker/workspace/build/src/obj-firefox/testing/geckodriver/./x86_64-unknown-linux-gnu/debug/deps/libunicode_segmentation-9242c3dda5ea9ed0.rlib --extern url=/builds/worker/workspace/build/src/obj-firefox/testing/geckodriver/./x86_64-unknown-linux-gnu/debug/deps/liburl-a5211cde5ace48e6.rlib --extern webdriver=/builds/worker/workspace/build/src/obj-firefox/testing/geckodriver/./x86_64-unknown-linux-gnu/debug/deps/libwebdriver-7d2a094f8f78265a.rlib`
[task 2018-09-27T14:02:32.747Z] 14:02:32     INFO -    Compiling style_traits v0.0.1 (file:///builds/worker/workspace/build/src/servo/components/style_traits)
[task 2018-09-27T14:02:32.749Z] 14:02:32     INFO -      Running `/builds/worker/workspace/build/src/sccache2/sccache /builds/worker/workspace/build/src/rustc/bin/rustc --crate-name style_traits servo/components/style_traits/lib.rs --crate-type lib --emit=dep-info,link -C opt-level=1 -C debuginfo=2 -C debug-assertions=on --cfg 'feature="gecko"' -C metadata=5c3156439b75c4f9 -C extra-filename=-5c3156439b75c4f9 --out-dir /builds/worker/workspace/build/src/obj-firefox/toolkit/library/x86_64-unknown-linux-gnu/debug/deps --target x86_64-unknown-linux-gnu -C linker=/builds/worker/workspace/build/src/build/cargo-linker -L dependency=/builds/worker/workspace/build/src/obj-firefox/toolkit/library/x86_64-unknown-linux-gnu/debug/deps -L dependency=/builds/worker/workspace/build/src/obj-firefox/toolkit/library/debug/deps --extern app_units=/builds/worker/workspace/build/src/obj-firefox/toolkit/library/x86_64-unknown-linux-gnu/debug/deps/libapp_units-294d02718671a136.rlib --extern bitflags=/builds/worker/workspace/build/src/obj-firefox/toolkit/library/x86_64-unknown-linux-gnu/debug/deps/libbitflags-c07bb682e7f6c247.rlib --extern cssparser=/builds/worker/workspace/build/src/obj-firefox/toolkit/library/x86_64-unknown-linux-gnu/debug/deps/libcssparser-e740f21561602fb8.rlib --extern euclid=/builds/worker/workspace/build/src/obj-firefox/toolkit/library/x86_64-unknown-linux-gnu/debug/deps/libeuclid-39dad98f26caea06.rlib --extern malloc_size_of=/builds/worker/workspace/build/src/obj-firefox/toolkit/library/x86_64-unknown-linux-gnu/debug/deps/libmalloc_size_of-4270ba7cc2afb355.rlib --extern malloc_size_of_derive=/builds/worker/workspace/build/src/obj-firefox/toolkit/library/debug/deps/libmalloc_size_of_derive-913cee0224177699.so --extern selectors=/builds/worker/workspace/build/src/obj-firefox/toolkit/library/x86_64-unknown-linux-gnu/debug/deps/libselectors-f36c6c51cbd9dd47.rlib --extern servo_arc=/builds/worker/workspace/build/src/obj-firefox/toolkit/library/x86_64-unknown-linux-gnu/debug/deps/libservo_arc-1de53d32a3c55a3e.rlib -C opt-level=2 -C debuginfo=2`
[task 2018-09-27T14:02:33.005Z] 14:02:33     INFO -    Compiling style v0.0.1 (file:///builds/worker/workspace/build/src/servo/components/style)
[task 2018-09-27T14:02:33.011Z] 14:02:33     INFO -      Running `/builds/worker/workspace/build/src/sccache2/sccache /builds/worker/workspace/build/src/rustc/bin/rustc --crate-name style servo/components/style/lib.rs --crate-type lib --emit=dep-info,link -C opt-level=1 -C debuginfo=2 -C debug-assertions=on --cfg 'feature="bindgen"' --cfg 'feature="fallible"' --cfg 'feature="gecko"' --cfg 'feature="gecko_debug"' --cfg 'feature="nsstring"' --cfg 'feature="num_cpus"' --cfg 'feature="regex"' --cfg 'feature="style_traits"' --cfg 'feature="toml"' --cfg 'feature="use_bindgen"' -C metadata=69248e683f80c4ba -C extra-filename=-69248e683f80c4ba --out-dir /builds/worker/workspace/build/src/obj-firefox/toolkit/library/x86_64-unknown-linux-gnu/debug/deps --target x86_64-unknown-linux-gnu -C linker=/builds/worker/workspace/build/src/build/cargo-linker -L dependency=/builds/worker/workspace/build/src/obj-firefox/toolkit/library/x86_64-unknown-linux-gnu/debug/deps -L dependency=/builds/worker/workspace/build/src/obj-firefox/toolkit/library/debug/deps --extern app_units=/builds/worker/workspace/build/src/obj-firefox/toolkit/library/x86_64-unknown-linux-gnu/debug/deps/libapp_units-294d02718671a136.rlib --extern arrayvec=/builds/worker/workspace/build/src/obj-firefox/toolkit/library/x86_64-unknown-linux-gnu/debug/deps/libarrayvec-087d8dc81a15630f.rlib --extern atomic_refcell=/builds/worker/workspace/build/src/obj-firefox/toolkit/library/x86_64-unknown-linux-gnu/debug/deps/libatomic_refcell-42e7f5b959cb6d6d.rlib --extern bitflags=/builds/worker/workspace/build/src/obj-firefox/toolkit/library/x86_64-unknown-linux-gnu/debug/deps/libbitflags-c07bb682e7f6c247.rlib --extern byteorder=/builds/worker/workspace/build/src/obj-firefox/toolkit/library/x86_64-unknown-linux-gnu/debug/deps/libbyteorder-d243cdda93a5b22c.rlib --extern cfg_if=/builds/worker/workspace/build/src/obj-firefox/toolkit/library/x86_64-unknown-linux-gnu/debug/deps/libcfg_if-ca875b3fc91b3593.rlib --extern cssparser=/builds/worker/workspace/build/src/obj-firefox/toolkit/library/x86_64-unknown-linux-gnu/debug/deps/libcssparser-e740f21561602fb8.rlib --extern euclid=/builds/worker/workspace/build/src/obj-firefox/toolkit/library/x86_64-unknown-linux-gnu/debug/deps/libeuclid-39dad98f26caea06.rlib --extern fallible=/builds/worker/workspace/build/src/obj-firefox/toolkit/library/x86_64-unknown-linux-gnu/debug/deps/libfallible-f989d44f43803998.rlib --extern fxhash=/builds/worker/workspace/build/src/obj-firefox/toolkit/library/x86_64-unknown-linux-gnu/debug/deps/libfxhash-934dfa594a148e5b.rlib --extern hashglobe=/builds/worker/workspace/build/src/obj-firefox/toolkit/library/x86_64-unknown-linux-gnu/debug/deps/libhashglobe-0c8dabd08687f4f4.rlib --extern itertools=/builds/worker/workspace/build/src/obj-firefox/toolkit/library/x86_64-unknown-linux-gnu/debug/deps/libitertools-bcdcda756b9cf086.rlib --extern itoa=/builds/worker/workspace/build/src/obj-firefox/toolkit/library/x86_64-unknown-linux-gnu/debug/deps/libitoa-e9e3823d1b117b6e.rlib --extern lazy_static=/builds/worker/workspace/build/src/obj-firefox/toolkit/library/x86_64-unknown-linux-gnu/debug/deps/liblazy_static-01911f712b43e365.rlib --extern log=/builds/worker/workspace/build/src/obj-firefox/toolkit/library/x86_64-unknown-linux-gnu/debug/deps/liblog-7b229d569789bee4.rlib --extern malloc_size_of=/builds/worker/workspace/build/src/obj-firefox/toolkit/library/x86_64-unknown-linux-gnu/debug/deps/libmalloc_size_of-4270ba7cc2afb355.rlib --extern malloc_size_of_derive=/builds/worker/workspace/build/src/obj-firefox/toolkit/library/debug/deps/libmalloc_size_of_derive-913cee0224177699.so --extern matches=/builds/worker/workspace/build/src/obj-firefox/toolkit/library/x86_64-unknown-linux-gnu/debug/deps/libmatches-1726075aa8b31614.rlib --extern debug_unreachable=/builds/worker/workspace/build/src/obj-firefox/toolkit/library/x86_64-unknown-linux-gnu/debug/deps/libdebug_unreachable-998af7f8fa0cbdd3.rlib --extern nsstring=/builds/worker/workspace/build/src/obj-firefox/toolkit/library/x86_64-unknown-linux-gnu/debug/deps/libnsstring-e1ca0d5d813b19ce.rlib --extern num_derive=/builds/worker/workspace/build/src/obj-firefox/toolkit/library/debug/deps/libnum_derive-94c1915c550c4c0b.so --extern num_integer=/builds/worker/workspace/build/src/obj-firefox/toolkit/library/x86_64-unknown-linux-gnu/debug/deps/libnum_integer-648cd465ffa9f4b1.rlib --extern num_traits=/builds/worker/workspace/build/src/obj-firefox/toolkit/library/x86_64-unknown-linux-gnu/debug/deps/libnum_traits-73083aaa0584c5c1.rlib --extern num_cpus=/builds/worker/workspace/build/src/obj-firefox/toolkit/library/x86_64-unknown-linux-gnu/debug/deps/libnum_cpus-345859933ed4e834.rlib --extern ordered_float=/builds/worker/workspace/build/src/obj-firefox/toolkit/library/x86_64-unknown-linux-gnu/debug/deps/libordered_float-4749cf34a302f721.rlib --extern owning_ref=/builds/worker/workspace/build/src/obj-firefox/toolkit/library/x86_64-unknown-linux-gnu/debug/deps/libowning_ref-d7dd8526f74087c8.rlib --extern parking_lot=/builds/worker/workspace/build/src/obj-firefox/toolkit/library/x86_64-unknown-linux-gnu/debug/deps/libparking_lot-379aaeef5a80a61d.rlib --extern precomputed_hash=/builds/worker/workspace/build/src/obj-firefox/toolkit/library/x86_64-unknown-linux-gnu/debug/deps/libprecomputed_hash-a80d44b64dfcd55f.rlib --extern rayon=/builds/worker/workspace/build/src/obj-firefox/toolkit/library/x86_64-unknown-linux-gnu/debug/deps/librayon-ba3fdd720d0f2517.rlib --extern selectors=/builds/worker/workspace/build/src/obj-firefox/toolkit/library/x86_64-unknown-linux-gnu/debug/deps/libselectors-f36c6c51cbd9dd47.rlib --extern servo_arc=/builds/worker/workspace/build/src/obj-firefox/toolkit/library/x86_64-unknown-linux-gnu/debug/deps/libservo_arc-1de53d32a3c55a3e.rlib --extern smallbitvec=/builds/worker/workspace/build/src/obj-firefox/toolkit/library/x86_64-unknown-linux-gnu/debug/deps/libsmallbitvec-ade152b52316a4a4.rlib --extern smallvec=/builds/worker/workspace/build/src/obj-firefox/toolkit/library/x86_64-unknown-linux-gnu/debug/deps/libsmallvec-68adc1c103880e64.rlib --extern style_derive=/builds/worker/workspace/build/src/obj-firefox/toolkit/library/debug/deps/libstyle_derive-16e352c046c7f2f9.so --extern style_traits=/builds/worker/workspace/build/src/obj-firefox/toolkit/library/x86_64-unknown-linux-gnu/debug/deps/libstyle_traits-5c3156439b75c4f9.rlib --extern thin_slice=/builds/worker/workspace/build/src/obj-firefox/toolkit/library/x86_64-unknown-linux-gnu/debug/deps/libthin_slice-b70092b0d721f244.rlib --extern time=/builds/worker/workspace/build/src/obj-firefox/toolkit/library/x86_64-unknown-linux-gnu/debug/deps/libtime-ef7e5cb3cc7eca8a.rlib --extern uluru=/builds/worker/workspace/build/src/obj-firefox/toolkit/library/x86_64-unknown-linux-gnu/debug/deps/libuluru-3102219ecdfd375d.rlib --extern unicode_bidi=/builds/worker/workspace/build/src/obj-firefox/toolkit/library/x86_64-unknown-linux-gnu/debug/deps/libunicode_bidi-4034686bf29d7dda.rlib --extern unicode_segmentation=/builds/worker/workspace/build/src/obj-firefox/toolkit/library/x86_64-unknown-linux-gnu/debug/deps/libunicode_segmentation-9242c3dda5ea9ed0.rlib --extern void=/builds/worker/workspace/build/src/obj-firefox/toolkit/library/x86_64-unknown-linux-gnu/debug/deps/libvoid-d89b1ee45933a105.rlib -C opt-level=2 -C debuginfo=2`
[task 2018-09-27T14:02:33.123Z] 14:02:33     INFO - running 0 tests
[task 2018-09-27T14:02:33.123Z] 14:02:33     INFO - test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out
[task 2018-09-27T14:02:33.125Z] 14:02:33     INFO -    Doc-tests mozprofile
[task 2018-09-27T14:02:33.125Z] 14:02:33     INFO -      Running `/builds/worker/workspace/build/src/rustc/bin/rustdoc --test /builds/worker/workspace/build/src/testing/mozbase/rust/mozprofile/src/lib.rs --crate-name mozprofile -L dependency=/builds/worker/workspace/build/src/obj-firefox/testing/geckodriver/./x86_64-unknown-linux-gnu/debug/deps -L native=/builds/worker/workspace/build/src/obj-firefox/testing/geckodriver/./x86_64-unknown-linux-gnu/debug/build/bzip2-sys-fa2c502c56a85589/out -L dependency=/builds/worker/workspace/build/src/obj-firefox/testing/geckodriver/./debug/deps --extern mozprofile=/builds/worker/workspace/build/src/obj-firefox/testing/geckodriver/./x86_64-unknown-linux-gnu/debug/deps/libmozprofile-e0c51b3ca2554e45.rlib --extern tempdir=/builds/worker/workspace/build/src/obj-firefox/testing/geckodriver/./x86_64-unknown-linux-gnu/debug/deps/libtempdir-afa04b4bcb4fb011.rlib`
[task 2018-09-27T14:02:33.201Z] 14:02:33     INFO - running 0 tests
[task 2018-09-27T14:02:33.201Z] 14:02:33     INFO - test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out
[task 2018-09-27T14:02:33.201Z] 14:02:33     INFO -    Doc-tests mozrunner
[task 2018-09-27T14:02:33.202Z] 14:02:33     INFO -      Running `/builds/worker/workspace/build/src/rustc/bin/rustdoc --test /builds/worker/workspace/build/src/testing/mozbase/rust/mozrunner/src/lib.rs --crate-name mozrunner -L dependency=/builds/worker/workspace/build/src/obj-firefox/testing/geckodriver/./x86_64-unknown-linux-gnu/debug/deps -L native=/builds/worker/workspace/build/src/obj-firefox/testing/geckodriver/./x86_64-unknown-linux-gnu/debug/build/bzip2-sys-fa2c502c56a85589/out -L dependency=/builds/worker/workspace/build/src/obj-firefox/testing/geckodriver/./debug/deps --extern log=/builds/worker/workspace/build/src/obj-firefox/testing/geckodriver/./x86_64-unknown-linux-gnu/debug/deps/liblog-c6b1d73daba0b492.rlib --extern mozprofile=/builds/worker/workspace/build/src/obj-firefox/testing/geckodriver/./x86_64-unknown-linux-gnu/debug/deps/libmozprofile-e0c51b3ca2554e45.rlib --extern mozrunner=/builds/worker/workspace/build/src/obj-firefox/testing/geckodriver/./x86_64-unknown-linux-gnu/debug/deps/libmozrunner-f7754123701ce644.rlib`
[task 2018-09-27T14:02:33.278Z] 14:02:33     INFO - running 0 tests
[task 2018-09-27T14:02:33.278Z] 14:02:33     INFO - test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out
[task 2018-09-27T14:02:33.278Z] 14:02:33     INFO -    Doc-tests mozversion
[task 2018-09-27T14:02:33.278Z] 14:02:33     INFO -      Running `/builds/worker/workspace/build/src/rustc/bin/rustdoc --test /builds/worker/workspace/build/src/testing/mozbase/rust/mozversion/src/lib.rs --crate-name mozversion -L dependency=/builds/worker/workspace/build/src/obj-firefox/testing/geckodriver/./x86_64-unknown-linux-gnu/debug/deps -L native=/builds/worker/workspace/build/src/obj-firefox/testing/geckodriver/./x86_64-unknown-linux-gnu/debug/build/bzip2-sys-fa2c502c56a85589/out -L dependency=/builds/worker/workspace/build/src/obj-firefox/testing/geckodriver/./debug/deps --extern mozversion=/builds/worker/workspace/build/src/obj-firefox/testing/geckodriver/./x86_64-unknown-linux-gnu/debug/deps/libmozversion-388a80f7b8673d6a.rlib --extern regex=/builds/worker/workspace/build/src/obj-firefox/testing/geckodriver/./x86_64-unknown-linux-gnu/debug/deps/libregex-136dd60c9245c20e.rlib --extern ini=/builds/worker/workspace/build/src/obj-firefox/testing/geckodriver/./x86_64-unknown-linux-gnu/debug/deps/libini-99151a82e2fadf5d.rlib --extern semver=/builds/worker/workspace/build/src/obj-firefox/testing/geckodriver/./x86_64-unknown-linux-gnu/debug/deps/libsemver-53eb0aae015c1740.rlib`
[task 2018-09-27T14:02:33.346Z] 14:02:33     INFO - running 0 tests
[task 2018-09-27T14:02:33.346Z] 14:02:33     INFO - test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out
[task 2018-09-27T14:02:33.349Z] 14:02:33     INFO - error: test failed, to rerun pass '--bin geckodriver'
[task 2018-09-27T14:02:33.349Z] 14:02:33     INFO - /builds/worker/workspace/build/src/config/rules.mk:1065: recipe for target 'force-cargo-test-run' failed
[task 2018-09-27T14:02:33.349Z] 14:02:33     INFO - make[2]: *** [force-cargo-test-run] Error 101
[task 2018-09-27T14:02:33.350Z] 14:02:33     INFO - make[2]: Target 'check' not remade because of errors.
[task 2018-09-27T14:02:33.350Z] 14:02:33     INFO - make[2]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/testing/geckodriver'
[task 2018-09-27T14:02:33.350Z] 14:02:33     INFO - /builds/worker/workspace/build/src/config/recurse.mk:101: recipe for target 'testing/geckodriver/check' failed
[task 2018-09-27T14:02:33.350Z] 14:02:33     INFO - make[1]: *** [testing/geckodriver/check] Error 2
[task 2018-09-27T14:02:45.634Z] 14:02:45     INFO -    Compiling geckoservo v0.0.1 (file:///builds/worker/workspace/build/src/servo/ports/geckolib)
[task 2018-09-27T14:02:45.635Z] 14:02:45     INFO -      Running `/builds/worker/workspace/build/src/sccache2/sccache /builds/worker/workspace/build/src/rustc/bin/rustc --crate-name geckoservo servo/ports/geckolib/lib.rs --crate-type lib --emit=dep-info,link -C opt-level=1 -C debuginfo=2 -C debug-assertions=on --cfg 'feature="bindgen"' --cfg 'feature="gecko_debug"' --cfg 'feature="nsstring"' --cfg 'feature="style"' -C metadata=76b4b9b9c1ec09b7 -C extra-filename=-76b4b9b9c1ec09b7 --out-dir /builds/worker/workspace/build/src/obj-firefox/toolkit/library/x86_64-unknown-linux-gnu/debug/deps --target x86_64-unknown-linux-gnu -C linker=/builds/worker/workspace/build/src/build/cargo-linker -L dependency=/builds/worker/workspace/build/src/obj-firefox/toolkit/library/x86_64-unknown-linux-gnu/debug/deps -L dependency=/builds/worker/workspace/build/src/obj-firefox/toolkit/library/debug/deps --extern atomic_refcell=/builds/worker/workspace/build/src/obj-firefox/toolkit/library/x86_64-unknown-linux-gnu/debug/deps/libatomic_refcell-42e7f5b959cb6d6d.rlib --extern cssparser=/builds/worker/workspace/build/src/obj-firefox/toolkit/library/x86_64-unknown-linux-gnu/debug/deps/libcssparser-e740f21561602fb8.rlib --extern cstr=/builds/worker/workspace/build/src/obj-firefox/toolkit/library/x86_64-unknown-linux-gnu/debug/deps/libcstr-06f5d5121c9fce12.rlib --extern libc=/builds/worker/workspace/build/src/obj-firefox/toolkit/library/x86_64-unknown-linux-gnu/debug/deps/liblibc-8e656a43d6716132.rlib --extern log=/builds/worker/workspace/build/src/obj-firefox/toolkit/library/x86_64-unknown-linux-gnu/debug/deps/liblog-7b229d569789bee4.rlib --extern malloc_size_of=/builds/worker/workspace/build/src/obj-firefox/toolkit/library/x86_64-unknown-linux-gnu/debug/deps/libmalloc_size_of-4270ba7cc2afb355.rlib --extern nsstring=/builds/worker/workspace/build/src/obj-firefox/toolkit/library/x86_64-unknown-linux-gnu/debug/deps/libnsstring-e1ca0d5d813b19ce.rlib --extern num_traits=/builds/worker/workspace/build/src/obj-firefox/toolkit/library/x86_64-unknown-linux-gnu/debug/deps/libnum_traits-73083aaa0584c5c1.rlib --extern parking_lot=/builds/worker/workspace/build/src/obj-firefox/toolkit/library/x86_64-unknown-linux-gnu/debug/deps/libparking_lot-379aaeef5a80a61d.rlib --extern selectors=/builds/worker/workspace/build/src/obj-firefox/toolkit/library/x86_64-unknown-linux-gnu/debug/deps/libselectors-f36c6c51cbd9dd47.rlib --extern servo_arc=/builds/worker/workspace/build/src/obj-firefox/toolkit/library/x86_64-unknown-linux-gnu/debug/deps/libservo_arc-1de53d32a3c55a3e.rlib --extern smallvec=/builds/worker/workspace/build/src/obj-firefox/toolkit/library/x86_64-unknown-linux-gnu/debug/deps/libsmallvec-68adc1c103880e64.rlib --extern style=/builds/worker/workspace/build/src/obj-firefox/toolkit/library/x86_64-unknown-linux-gnu/debug/deps/libstyle-69248e683f80c4ba.rlib --extern style_traits=/builds/worker/workspace/build/src/obj-firefox/toolkit/library/x86_64-unknown-linux-gnu/debug/deps/libstyle_traits-5c3156439b75c4f9.rlib -C opt-level=2 -C debuginfo=2`
[task 2018-09-27T14:02:47.294Z] 14:02:47     INFO -      Running `/builds/worker/workspace/build/src/sccache2/sccache /builds/worker/workspace/build/src/rustc/bin/rustc --crate-name stylo_tests servo/ports/geckolib/tests/lib.rs --emit=dep-info,link -C debuginfo=2 --test -C metadata=b10b541cc62c0947 -C extra-filename=-b10b541cc62c0947 --out-dir /builds/worker/workspace/build/src/obj-firefox/toolkit/library/x86_64-unknown-linux-gnu/debug/deps --target x86_64-unknown-linux-gnu -C linker=/builds/worker/workspace/build/src/build/cargo-linker -L dependency=/builds/worker/workspace/build/src/obj-firefox/toolkit/library/x86_64-unknown-linux-gnu/debug/deps -L dependency=/builds/worker/workspace/build/src/obj-firefox/toolkit/library/debug/deps --extern atomic_refcell=/builds/worker/workspace/build/src/obj-firefox/toolkit/library/x86_64-unknown-linux-gnu/debug/deps/libatomic_refcell-42e7f5b959cb6d6d.rlib --extern cssparser=/builds/worker/workspace/build/src/obj-firefox/toolkit/library/x86_64-unknown-linux-gnu/debug/deps/libcssparser-e740f21561602fb8.rlib --extern cstr=/builds/worker/workspace/build/src/obj-firefox/toolkit/library/x86_64-unknown-linux-gnu/debug/deps/libcstr-06f5d5121c9fce12.rlib --extern env_logger=/builds/worker/workspace/build/src/obj-firefox/toolkit/library/x86_64-unknown-linux-gnu/debug/deps/libenv_logger-d8a6a967378da7f5.rlib --extern geckoservo=/builds/worker/workspace/build/src/obj-firefox/toolkit/library/x86_64-unknown-linux-gnu/debug/deps/libgeckoservo-76b4b9b9c1ec09b7.rlib --extern libc=/builds/worker/workspace/build/src/obj-firefox/toolkit/library/x86_64-unknown-linux-gnu/debug/deps/liblibc-8e656a43d6716132.rlib --extern log=/builds/worker/workspace/build/src/obj-firefox/toolkit/library/x86_64-unknown-linux-gnu/debug/deps/liblog-7b229d569789bee4.rlib --extern malloc_size_of=/builds/worker/workspace/build/src/obj-firefox/toolkit/library/x86_64-unknown-linux-gnu/debug/deps/libmalloc_size_of-4270ba7cc2afb355.rlib --extern num_traits=/builds/worker/workspace/build/src/obj-firefox/toolkit/library/x86_64-unknown-linux-gnu/debug/deps/libnum_traits-73083aaa0584c5c1.rlib --extern selectors=/builds/worker/workspace/build/src/obj-firefox/toolkit/library/x86_64-unknown-linux-gnu/debug/deps/libselectors-f36c6c51cbd9dd47.rlib --extern size_of_test=/builds/worker/workspace/build/src/obj-firefox/toolkit/library/x86_64-unknown-linux-gnu/debug/deps/libsize_of_test-bfe8a190240d96ee.rlib --extern smallvec=/builds/worker/workspace/build/src/obj-firefox/toolkit/library/x86_64-unknown-linux-gnu/debug/deps/libsmallvec-68adc1c103880e64.rlib --extern style=/builds/worker/workspace/build/src/obj-firefox/toolkit/library/x86_64-unknown-linux-gnu/debug/deps/libstyle-69248e683f80c4ba.rlib --extern style_traits=/builds/worker/workspace/build/src/obj-firefox/toolkit/library/x86_64-unknown-linux-gnu/debug/deps/libstyle_traits-5c3156439b75c4f9.rlib -C opt-level=2 -C debuginfo=2 --cfg linking_with_gecko`
[task 2018-09-27T14:02:52.242Z] 14:02:52     INFO -     Finished dev [optimized + debuginfo] target(s) in 47.46s
[task 2018-09-27T14:02:52.263Z] 14:02:52     INFO -      Running `/builds/worker/workspace/build/src/obj-firefox/toolkit/library/debug/deps/malloc_size_of_derive-c48faf897fa13cf6`
[task 2018-09-27T14:02:52.271Z] 14:02:52     INFO - running 2 tests
[task 2018-09-27T14:02:52.271Z] 14:02:52     INFO - test test_struct ... ok
[task 2018-09-27T14:02:52.295Z] 14:02:52     INFO - test test_no_reason ... ok
[task 2018-09-27T14:02:52.295Z] 14:02:52     INFO - test result: ok. 2 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out
[task 2018-09-27T14:02:52.295Z] 14:02:52     INFO -      Running `/builds/worker/workspace/build/src/obj-firefox/toolkit/library/x86_64-unknown-linux-gnu/debug/deps/selectors-64b3440756864036`
[task 2018-09-27T14:02:52.298Z] 14:02:52     INFO - running 7 tests
[task 2018-09-27T14:02:52.299Z] 14:02:52     INFO - test parser::tests::test_empty ... ok
[task 2018-09-27T14:02:52.299Z] 14:02:52     INFO - test parser::tests::test_empty_pseudo_iter ... ok
[task 2018-09-27T14:02:52.300Z] 14:02:52     INFO - test bloom::create_and_insert_some_stuff ... ok
[task 2018-09-27T14:02:52.300Z] 14:02:52     INFO - test parser::tests::test_pseudo_iter ... ok
[task 2018-09-27T14:02:52.300Z] 14:02:52     INFO - test parser::tests::test_universal ... ok
[task 2018-09-27T14:02:52.300Z] 14:02:52     INFO - test parser::tests::visitor ... ok
[task 2018-09-27T14:02:52.300Z] 14:02:52     INFO - test parser::tests::test_parsing ... ok
[task 2018-09-27T14:02:52.300Z] 14:02:52     INFO - test result: ok. 7 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out
[task 2018-09-27T14:02:52.300Z] 14:02:52     INFO -      Running `/builds/worker/workspace/build/src/obj-firefox/toolkit/library/x86_64-unknown-linux-gnu/debug/deps/servo_arc-27da9d16d35716eb`
[task 2018-09-27T14:02:52.303Z] 14:02:52     INFO - running 1 test
[task 2018-09-27T14:02:52.303Z] 14:02:52     INFO - test tests::slices_and_thin ... ok
[task 2018-09-27T14:02:52.304Z] 14:02:52     INFO - test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out
Flags: needinfo?(ato)

Comment 14

9 months ago
Pushed by ato@sny.no:
https://hg.mozilla.org/integration/mozilla-inbound/rev/149937b6d675
geckodriver: remove unnecessary owned string conversion r=whimboo
https://hg.mozilla.org/integration/mozilla-inbound/rev/58fa774c911e
geckodriver: drop try!() macro from MarionetteHandler r=whimboo
https://hg.mozilla.org/integration/mozilla-inbound/rev/52f567d78430
geckodriver: log reason for not being able to write profile r=whimboo
https://hg.mozilla.org/integration/mozilla-inbound/rev/baff8a950809
mozprofile: add docs for Pref::new and ::new_sticky r=whimboo
https://hg.mozilla.org/integration/mozilla-inbound/rev/0fcb85b4c2f2
geckodriver: convert logging::Level to Pref r=whimboo
Assignee

Comment 15

9 months ago
The tests in logging.rs sets the global log level, and because cargo
runs test in parallel this can intermittently cause the log level
to be something else than "Fatal".  To work around this problem
I’ve changed the profile test to check that the string starts with
an uppercase letter.
Flags: needinfo?(ato)
You need to log in before you can comment on or make changes to this bug.