Closed Bug 1494625 Opened Last year Closed Last year

Support struct field names in wast text

Categories

(Core :: Javascript: WebAssembly, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: lth, Assigned: lth)

References

Details

Attachments

(1 file)

The spec [1] calls only for names that are unique within the module, so this is easy.  This uncovered a bug in a test case that violated that rule, but the field names were ignored so it wasn't caught until now.

[1] https://github.com/lars-t-hansen/moz-gc-experiments/blob/master/version1.md
Attachment #9012565 - Flags: review?(bbouvier)
Comment on attachment 9012565 [details] [diff] [review]
bug1494625-wast-struct-field-names.patch

Review of attachment 9012565 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, thanks.
Attachment #9012565 - Flags: review?(bbouvier) → review+
https://hg.mozilla.org/mozilla-central/rev/9a982ed1b28c
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.