Closed Bug 1494644 Opened 6 years ago Closed 6 years ago

[wpt-sync] Sync PR 13240 - WPT: service worker: Fix potential race in navigation-redirect.https.html.

Categories

(Testing :: web-platform-tests, enhancement, P4)

Product:
Testing
Component:
web-platform-tests
Type:
enhancement

Tracking

(firefox64 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla64
Tracking Flags:
Tracking Status
firefox64 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream]) 

Sync web-platform-tests PR 13240 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/13240
Details from upstream follow.

Matt Falkenhagen <falken@chromium.org> wrote:
>  WPT: service worker: Fix potential race in navigation-redirect.https.html.
>  
>  Before this CL, the test makes a frame which posts a message to the test
>  window. But if the test fails, we might not consume the message with
>  `await` and move on the next test. It's possible the next test gets an
>  unexpected message from the previous test.
>  
>  I think a related issue caused the timeout after the Clients variant was
>  added to the test, since the message handler was created after the frame
>  was created and it was possible the message arrived after that.
>  
>  Fix things by explicitly asking the frame for the message when we're
>  ready for it.
>  
>  Bug: 876223, 778497
>  Change-Id: I82b8685df2977aeadea7475965ecccf69bd33111
>  Reviewed-on: https://chromium-review.googlesource.com/1249423
>  WPT-Export-Revision: 0f8b2fb0e8dac8723274ca721a3cac4dd6c469c2
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Ran 1 tests and 37 subtests
OK     : 1
PASS   : 37
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bb2525c6a01b
[wpt PR 13240] - WPT: service worker: Fix potential race in navigation-redirect.https.html., a=testonly
https://hg.mozilla.org/mozilla-central/rev/bb2525c6a01b
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox64: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.