1494667 - "selectedJob" in the URL results in 'TypeError: "newSelectedElement is undefined; can't access its "setSelected" property"'

Status: RESOLVED FIXED

(Tree Management :: Treeherder: Frontend, defect, P1)

Description

[Ed Morley [:emorley]]

Visiting a page with `selectedJob=NNNN`, such as:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=455e34f839570cae2a2bdada66c14f0977fd64bf&selectedJob=200557050

...results in the the following exception:

`TypeError: "V is undefined; can't access its "setSelected" property"`

Reproducing locally the unminified version is:

`TypeError: "newSelectedElement is undefined; can't access its "setSelected" property"`

I've rolled back production for now, so no rush :-)

Comment 1

[Ed Morley [:emorley]]

See also bug 1479522 comment 3

Comment 2

[Cameron Dawson [:camd]]

Interesting.  This appears to happen if you've expanded a group of job counts (or they became grouped due to more jobs showing up) and selected one of those jobs.  Then when we try to re-select that job, we can't set the styling of "selected" because the "job" won't be found in the DOM.  I can make a simple check that will still show the details for that job, but not show it selected.  However, the better fix would be to detect which "group" the job belongs to and expand it so that the job element is visible.

Comment 3

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/4081

Comment 4

[Ed Morley [:emorley]]

I was hoping to try a prod deploy again soon, but it's blocked on fixing this.
Would it be possible to look at the Travis failures on this PR today? :-)

Comment 5

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/1b0eb3bbe866f82df2a0c309d042d2cd80adedcc
Bug 1494667 - Fix selecting job within count on page load (#4081)