1494672 - Regression: When you select a tag in the quick filter bar, that tag is no longer highlighted

Status: RESOLVED FIXED

(Thunderbird :: Toolbars and Tabs, defect)

Description

[David Cramer]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:62.0) Gecko/20100101 Firefox/62.0
Build ID: 20180830143136

Steps to reproduce:

Thunderbird 60.0 (64-bit)
macOS version 10.13.6

1. Click the Tags button on the Quick Filter bar
2. Click on a tag to filter the list of items



Actual results:

Items are filtered, but the tag in the Quick Filter Bar does not change, so there is no way to know which tag is selected. 


Expected results:

When I click on a tag, that tag should be highlighted (outlined) so that I can tell which tags are currently selected. This is how it worked in previous releases. This is especially challenging when tags do not have a color assigned or several tags have the same color assigned.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: bug1494672.patch

This makes also under all platforms the tag button appearance like the other QFP buttons.

The CSS code is needed to make the second toolbar not taller as without patch.

Comment 2

[Richard Marti (:Paenglab)]

Attachment: bug1494672-beta.patch

The same for beta.

Comment 3

[Jorg K (CEST = GMT+2)]

No Mac CSS changes here? This was reported for TB 60 ESR, so is there a patch for that?

Comment 4

[Jorg K (CEST = GMT+2)]

Hmm, buttons highlight in TB 60 ESR on Windows. But this was reported for Mac. Also, what is the regressing bug?

Comment 5

[Richard Marti (:Paenglab)]

For Mac the addition of the toolbarbutton-1 class is enough.

Comment 6

[Richard Marti (:Paenglab)]

Can't say which bug. Could be the QFB theming bug.

Comment 7

[Richard Marti (:Paenglab)]

Attachment: bug1494672-ESR.patch

Patch for ESR60. No change in Linux messenger.css needed because toolkit's toolbarbutton.css is loaded through xul.css and not as document stylesheet.

Comment 8

[Jorg K (CEST = GMT+2)]

Well, on Windows 10 the buttons highlight in TB 60 and on trunk and I see no change with the patch. However, I noticed some issues:
- the highlight is one pixel to short compared to the "Any/All" box to the left
- the highlight, or shall I say, "black-light" is barely visible with the Dark theme, no change with the patch.

So questions:
- Is TB 60 affected?
- What changes do you expect on Windows/Linux? Are the CSS changes necessary?
- Maybe a Mac reviewer would be do a better job here?

Comment 9

[Richard Marti (:Paenglab)]

Attachment: with-patch.png

(In reply to Jorg K (GMT+2) from comment #8)
> Well, on Windows 10 the buttons highlight in TB 60 and on trunk and I see no
> change with the patch. However, I noticed some issues:
> - the highlight is one pixel to short compared to the "Any/All" box to the
> left
> - the highlight, or shall I say, "black-light" is barely visible with the
> Dark theme, no change with the patch.

Is the patch applied correctly? here the tag buttons have no more blueish but whitish (on dark theme) highlight and the height is the same as by the other buttons.

> So questions:
> - Is TB 60 affected?

Yes

> - What changes do you expect on Windows/Linux? Are the CSS changes necessary?

Windows with dark theme the selected button background color is almost not visible.

> - Maybe a Mac reviewer would be do a better job here?

Not needed as Windows is affected too with the wrong selected background color.

Comment 10

[Jorg K (CEST = GMT+2)]

Comment on attachment 9012685 [details] [diff] [review]
bug1494672.patch

Sorry, I don't know what happened. Must not have applied the patch :-( - Not very good for the TB sheriff.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/5664e476f06c
Fix tag selection in QFB by adding the toolbarbutton-1 class to the qfb-tag-button. r=jorgk DONTBUILD

Comment 12

[Jorg K (CEST = GMT+2)]

TB 60.2 ESR:
https://hg.mozilla.org/releases/comm-esr60/rev/340ae0cd525b4112fb417b4492b15d27ced3d237

Please try the binaries from the build when it's done.

Comment 13

[Jorg K (CEST = GMT+2)]

Looking good in the ESR version on Windows, how about other platforms?

Comment 14

[Richard Marti (:Paenglab)]

Checked on Mac and Linux. Both looking good.

Comment 15

[Jorg K (CEST = GMT+2)]

Beta (TB 63):
https://hg.mozilla.org/releases/comm-beta/rev/0484252ec85a49bea494f64e8032c4a896ae20bb