1494690 - Set the right maxResults in UrlbarInput

Status: RESOLVED FIXED

(Firefox :: Address Bar, enhancement, P3)

Comment 1

[Dão Gottwald [:dao]]

Attachment: patch

Comment 2

[Mark Banner (:standard8)]

Comment on attachment 9012602 [details] [diff] [review]
patch

Review of attachment 9012602 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/urlbar/UrlbarInput.jsm
@@ +308,4 @@
>      this.controller.handleQuery(new QueryContext({
>        searchString: event.target.value,
>        lastKey: "",
> +      maxResults: UrlbarPrefs.get("maxRichResults"),

Can you extend browser_UrlbarInput_unit.js -> test_input_starts_query to test for this please? It is probably enough just to extend the call to `checkHandleQueryCall` with the results value from the pref.

Comment 3

[Dão Gottwald [:dao]]

Attachment: patch

Comment 4

[Mark Banner (:standard8)]

Comment on attachment 9012829 [details] [diff] [review]
patch

Review of attachment 9012829 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. I just realised that test_UrlbarController_integration.js is going to fail as well - I probably wrote it a bit early - its probably enough to change createContext in head.js to set maxResults to the pref, and then get test_basic_search to compare with the pref value.

Comment 5

[Dão Gottwald [:dao]]

Attachment: patch

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/89a23642630a
Set the right maxResults in UrlbarInput. r=standard8

Comment 7

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/89a23642630a