Closed Bug 1494690 Opened 1 year ago Closed 1 year ago

Set the right maxResults in UrlbarInput

Categories

(Firefox :: Address Bar, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
Firefox 64
Tracking Status
firefox64 --- fixed

People

(Reporter: dao, Assigned: dao)

References

Details

Attachments

(1 file, 2 obsolete files)

No description provided.
Attached patch patch (obsolete) — Splinter Review
Attachment #9012602 - Flags: review?(standard8)
Blocks: 1490028
Comment on attachment 9012602 [details] [diff] [review]
patch

Review of attachment 9012602 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/urlbar/UrlbarInput.jsm
@@ +308,4 @@
>      this.controller.handleQuery(new QueryContext({
>        searchString: event.target.value,
>        lastKey: "",
> +      maxResults: UrlbarPrefs.get("maxRichResults"),

Can you extend browser_UrlbarInput_unit.js -> test_input_starts_query to test for this please? It is probably enough just to extend the call to `checkHandleQueryCall` with the results value from the pref.
Attachment #9012602 - Flags: review?(standard8)
Attached patch patch (obsolete) — Splinter Review
Attachment #9012602 - Attachment is obsolete: true
Attachment #9012829 - Flags: review?(standard8)
Comment on attachment 9012829 [details] [diff] [review]
patch

Review of attachment 9012829 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. I just realised that test_UrlbarController_integration.js is going to fail as well - I probably wrote it a bit early - its probably enough to change createContext in head.js to set maxResults to the pref, and then get test_basic_search to compare with the pref value.
Attachment #9012829 - Flags: review?(standard8) → review+
Attached patch patchSplinter Review
Attachment #9012829 - Attachment is obsolete: true
Keywords: checkin-needed
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/89a23642630a
Set the right maxResults in UrlbarInput. r=standard8
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/89a23642630a
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
You need to log in before you can comment on or make changes to this bug.