1494740 - The ability to disable protection and report a problem are offered only if protection is enabled and the related resources are also blocked

Status: RESOLVED INVALID

(Firefox :: Protections UI, defect)

Description

[Iulia Cristescu, QA [:JuliaC] (away, please needinfo? [e-mail])]

[Affected versions]:
- 64.0a1 (2018-09-27)
- 63.0b9 build1 (20180924202103) 

[Affected platforms]:
- Windows 10 x64
- Ubuntu 16.04 x64
- macOS 10.13

[Steps to reproduce]:
Precondition: Content Blocking must be enabled (set browser.contentblocking.ui.enabled to true and restart the browser) if isn't already.
1. Launch Firefox
2. Open about:preferences#privacy and check the "Slow-Loading Trackers" entry from the Content Blocking section
3. Go to https://www.bbc.com/news and inspect the Site Information doorhanger

[Expected result]:
- The Slow-Loading Trackers are shown as blocked in the Site Information doorhanger
- The "Disable Blocking For This Site" and "Report a problem" controls are also available

[Actual result]:
- The "Disable Blocking For This Site" and "Report a problem" controls are missing from the Site Information doorhanger, although the slow-loading trackers protection is enabled
- Web Console logs are showing that no slow-loading resources are detected/blocked
- For more details, see the following screenshot https://drive.google.com/file/d/1NvHwS1Z8FrbnFKzYNrIDWsCQSgr47sjg/view?usp=sharing

[Regression range]:
- This issue is triggered by bug 1492576

Comment 1

[(no longer active)]

This is as designed, the UI has just gotten even more confusing than it was before now. :-(

Here is what is happening.  Trackers are being detected, so the content blocking details are visible.  The UI is saying slow trackers are "Blocked" because that's what the pref is set to.  But we are not offering the Disable Protections button or the Report Breakage button because nothing is actually blocked.

Will users understand this?  Probably not.  But this UI is behaving as the code in bug 1492576 changed things.

Comment 2

[Tanvi Vyas[:tanvi]]

This is intentional.  In firefox 63, the blocked state in the Control Center is based on the global pref and based on whether there are trackers present on the page.  In the case of fastblock, trackers may be present but not blocked, hence slow trackers are not detected.  If nothing is blocked, we shouldn't offer the user a way to disable protection.

In a later version of Firefox, we plan to change this so that the Control Center only shows things we detected or detected and blocked.

Thanks!

Comment 3

[Iulia Cristescu, QA [:JuliaC] (away, please needinfo? [e-mail])]

I based my report on the fact that bug 1492576 was offering this solution: "If no protection is enabled, don't offer the user the ability to disable protection or report a problem." - in the case I was stated, the protection is enabled, as the related settings are ON. That was my logic.