Closed Bug 1494742 Opened Last year Closed Last year

Port bug 1493276: Fix static assert errors "don't use CallQueryInterface for compile-time-determinable casts"

Categories

(MailNews Core :: General, task)

task
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 64.0

People

(Reporter: jorgk-bmo, Assigned: jorgk-bmo)

References

Details

Attachments

(1 file)

After applying
https://hg.mozilla.org/integration/autoland/rev/44e5267358eb
I got at least two compile errors in
mailnews/db/msgdb/src/nsMsgDatabase.cpp(3034,10) and
mailnews/compose/src/nsSmtpService.cpp(231,10)

I'll fix them now ;-)
Andrew, I saw you CC'ed yourself to the bug, maybe you'd like to do the review. Only six replacements. If not, I have a mailnews peer on stand-by.

Our review rules say that a Thunderbird peer can nominate any suitable reviewer ;-)
Attachment #9012680 - Flags: review?(continuation)
Attachment #9012680 - Flags: review?(continuation) → review+
Comment on attachment 9012680 [details] [diff] [review]
1494742-CallQueryInterface.patch

Thanks Andrew. The Calendar people want to be kept up to date if we touch their stuff, so I'll add another request here.
Attachment #9012680 - Flags: review?(makemyday)
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/42e6ccd2c53e
Port bug 1493276: Fix static assert errors 'don't use CallQueryInterface for compile-time-determinable casts'. r=mccr8
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 64.0
Attachment #9012680 - Flags: review?(makemyday) → review+
Type: defect → task
You need to log in before you can comment on or make changes to this bug.