1494758 - Debugger: jit-test/tests/debug/Environment-setVariable-WouldRun.js is messed up

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement, P2)

Description

[Jason Orendorff [:jorendorff]]

The comment says:

    // setVariable triggering a setter doesn't crash or explode.
    // It should throw WouldRunDebuggee, but that isn't implemented yet.

D'oh! This is incorrect; it is implemented. But if you change the test to expect that exception, the test fails because in this test case:


    test("with ({set x(v) {}}) eval(d());");

The test code `frame.environment.find("x")` does not find the environment containing the binding for `x`. That's because the test is looking in the environment of the function `d`, which is not inside the `with` block. D'oh again!

The actual Debugger API is working correctly; fix is test-only.

Comment 1

[Jason Orendorff [:jorendorff]]

Attachment: Bug 1494758 - Fix a multiply-busted Debugger test. r?jimb

Comment 2

[Steven DeTar [:sdetar]]

Assigning this bug to Jason since he seems to be working on it.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5cbc49176665
Fix a multiply-busted Debugger test. r=jimb

Comment 4

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/5cbc49176665