1494778 - CFR should respect the xpinstall.enabled pref

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[:Felipe Gomes (needinfo for replies!)]

The xpinstall.enabled pref is used by system administrators to disallow add-ons from being installed. If the pref is off, there should not be any recommendations for add-ons.

I tried to take a look at the code but I didn't find any references to this pref being checked. Apologies in advance if I missed it.

Comment 1

[:shell escalante]

Verified with ddurst and mkaply.  This pref is added by system admins to disable add-ons install.  

So if xpinstall.enabled pref is there and set to FALSE we should not make recommendations.

Comment 2

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4484

Comment 3

[[github robot]]

Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/e1dfcd0d3d7df9c61a677bf01f20d346675da79e
Fix Bug 1494778 - CFR should respect the xpinstall.enabled pref (#4484)

Comment 4

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/45bc3a854dd1

Comment 5

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that this issue is no longer reproducible with the latest Firefox Nightly (64.0a1 Build ID - 20181014223729) installed, on Windows 10 x64, Arch Linux and Mac 10.13.3. Now, CFR recommendations are no longer displayed if the "xpinstall.enabled" pref is set to "false" in the about:config" page.