Closed
Bug 1494828
Opened 7 years ago
Closed 7 years ago
[wpt-sync] Sync PR 13249 - Revert "[css-flexbox] Apply min-height: auto to nested flexboxes again"
Categories
(Testing :: web-platform-tests, enhancement, P4)
Testing
web-platform-tests
Tracking
(firefox64 fixed)
RESOLVED
FIXED
mozilla64
Tracking | Status | |
---|---|---|
firefox64 | --- | fixed |
People
(Reporter: wpt-sync, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 13249 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/13249
Details from upstream follow.
Wenzhao (Colin) Zang <wzang@chromium.org> wrote:
> Revert "[css-flexbox] Apply min-height: auto to nested flexboxes again"
>
> This reverts commit 35b382aa26d503c46963fdd6fa41bffe42cc7074.
>
> Reason for revert: crbug.com/890100
>
> Original change's description:
> > [css-flexbox] Apply min-height: auto to nested flexboxes again
> >
> > To avoid the previous regression (see analysis in bug), we force
> > layout in the case where we otherwise would get an outdated result.
> >
> > Bug: 596743
> > Change-Id: I9cf47675f7fcd88f94b2fe76b46bceae17e36756
> > Reviewed-on: https://chromium-review.googlesource.com/1246730
> > Commit-Queue: Christian Biesinger \<cbiesinger@chromium.org>
> > Reviewed-by: Morten Stenshorne \<mstensho@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#594752}
>
> TBR=cbiesinger@chromium.org,eae@chromium.org,mstensho@chromium.org
>
> Change-Id: I8ef1e6a3e5f191c495c0b36d32366de3f0323a39
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 596743
> Reviewed-on: https://chromium-review.googlesource.com/1250207
> Reviewed-by: Wenzhao (Colin) Zang \<wzang@chromium.org>
> Commit-Queue: Wenzhao (Colin) Zang \<wzang@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#594936}
>
Assignee | ||
Comment 1•7 years ago
|
||
PR 13249 applied with additional changes from upstream: 4d1d49da3fea8f6dc50ca57a16d42f99ac1632fe
Assignee | ||
Updated•7 years ago
|
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Assignee | ||
Updated•7 years ago
|
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Assignee | ||
Comment 2•7 years ago
|
||
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bda73f529c5d
[wpt PR 13249] - Revert "[css-flexbox] Apply min-height: auto to nested flexboxes again", a=testonly
Assignee | ||
Comment 4•7 years ago
|
||
Result changes from PR not available.
Comment 5•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in
before you can comment on or make changes to this bug.
Description
•