Closed Bug 1494828 Opened 7 years ago Closed 7 years ago

[wpt-sync] Sync PR 13249 - Revert "[css-flexbox] Apply min-height: auto to nested flexboxes again"

Categories

(Testing :: web-platform-tests, enhancement, P4)

enhancement

Tracking

(firefox64 fixed)

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 13249 into mozilla-central (this bug is closed when the sync is complete). PR: https://github.com/web-platform-tests/wpt/pull/13249 Details from upstream follow. Wenzhao (Colin) Zang <wzang@chromium.org> wrote: > Revert "[css-flexbox] Apply min-height: auto to nested flexboxes again" > > This reverts commit 35b382aa26d503c46963fdd6fa41bffe42cc7074. > > Reason for revert: crbug.com/890100 > > Original change's description: > > [css-flexbox] Apply min-height: auto to nested flexboxes again > > > > To avoid the previous regression (see analysis in bug), we force > > layout in the case where we otherwise would get an outdated result. > > > > Bug: 596743 > > Change-Id: I9cf47675f7fcd88f94b2fe76b46bceae17e36756 > > Reviewed-on: https://chromium-review.googlesource.com/1246730 > > Commit-Queue: Christian Biesinger \<cbiesinger@chromium.org> > > Reviewed-by: Morten Stenshorne \<mstensho@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#594752} > > TBR=cbiesinger@chromium.org,eae@chromium.org,mstensho@chromium.org > > Change-Id: I8ef1e6a3e5f191c495c0b36d32366de3f0323a39 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 596743 > Reviewed-on: https://chromium-review.googlesource.com/1250207 > Reviewed-by: Wenzhao (Colin) Zang \<wzang@chromium.org> > Commit-Queue: Wenzhao (Colin) Zang \<wzang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#594936} >
PR 13249 applied with additional changes from upstream: 4d1d49da3fea8f6dc50ca57a16d42f99ac1632fe
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/bda73f529c5d [wpt PR 13249] - Revert "[css-flexbox] Apply min-height: auto to nested flexboxes again", a=testonly
Result changes from PR not available.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.