149483 - many xpcom headers are not installed during a make install

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect, P1)

Description

[Christopher Blizzard (:blizzard)]

Lots of xpcom headers, including nsCOMPtr.h, aren't installed as part of make
install.  Patch to follow.

Comment 1

[Christopher Blizzard (:blizzard)]

Attachment: patch that exports SDK_HEADERS

Comment 2

[hacker formerly known as [e-mail]]

Comment on attachment 86546 [details] [diff] [review]
patch that exports SDK_HEADERS

r=cls

Comment 3

[hacker formerly known as [e-mail]]

Attachment: install XPIDLSRCS & SDK_XPIDLSRCS too

Comment 4

[hacker formerly known as [e-mail]]

Attachment: Use $(idldir) for idls

Comment 5

[hacker formerly known as [e-mail]]

Attachment: Fix nspr real_install issue when includedir is specified

Comment 6

[Christopher Blizzard (:blizzard)]

Attachment: patch that uses SYSINSTALL instead of INSTALL

Comment 7

[Christopher Blizzard (:blizzard)]

Attachment: patch that includes all of the bits and pieces

Comment 8

[Nathan G. Grennan]

*** Bug 149798 has been marked as a duplicate of this bug. ***

Comment 9

[Yanko Kaneti]

Unfortunately the -8 release of the RPMs is missing nsBuildID.h 

Comment 10

[Nathan G. Grennan]

I can verify that -8 doesn't include nsBuildID.h. Which I find to be required by
Galeon. I have also found that all the directories are missing from the list of
files created by rpm -ql mozilla-devel. So someone couldn't use rpm -qf
/usr/include/mozilla-1.0.0/expat , but could use rpm -qf
/usr/include/mozilla-1.0.0/expat/xmlparse.h   This has to do with a change in
the spec file between rc3 and 1.0. I would suggest this be fixed. I did a diff
of the files in mozilla-devel 1.0rc3 and 1.0.0-8 and found that the only file
missing is nsBuildID.h(well other than the directories I already mentioned). I
also found a number of .cfg files are missing ins mozilla-nspr-devel. In 1.0rc3
they were in mozilla-devel, but their section was moved to mozilla-nspr-devel in
1.0.0.

Comment 11

[Nathan G. Grennan]

-9 fixes the lack of nsBuildID.h, but still has a problem with lack of .cfg
files in mozilla-nspr-devel.

Oddly enough Ximian seems to have rpms that have all the files from what I can
tell. Their source rpm seems to have a one of the older patches attached to this
bug report, or something similar to it. It is much shortly than the latest
patches. I didn't look into it with great detail, but they managed to compile
Galeon 1.2.5 against it. So either they have a good source rpm or they did a
hack  job on the rpms and released a broken source rpm.

Comment 12

[Felix Braun (no longer active)]

Attachment: list of missing files in mozilla-devel-1.0.0-4.i386.rpm

I have tried to build skipstone with the mozilla-devel-1.0.0-4.rpm file and was
missing a couple of header files which I am attaching to this bug.

Comment 13

[Nathan G. Grennan]

Adding /usr/lib/mozilla-%{version} to /etc/ld.so.conf post install and removing
it post uninstall is a must, since nss and nspr libraries were moved out of
/usr/lib and into /usr/lib/mozilla-%{version}. Evolution behaves badly without it.


Here are the commands to do it:

echo "/usr/lib/mozilla-%{version}" >> /etc/ld.so.conf

/bin/cat /etc/ld.so.conf | grep -v "/usr/lib/mozilla-%{version}" > /etc/ld.so.conf

Comment 14

[Nathan G. Grennan]

I don't recommend using the commands I posted. They worked fine on the command
line, but I got an input/output error when uninstalling the rpm and it ate my
/etc/ld.so.conf. I have found RedHat has name evolution-1.0.5-2.4 which includes
a patch which makes the ld.so.conf entry unnecessary.

Comment 15

[Christopher Blizzard (:blizzard)]

Attachment: final patch

Comment 16

[hacker formerly known as [e-mail]]

Comment on attachment 86946 [details] [diff] [review]
final patch

r=cls

Comment 17

[Nathan G. Grennan]

Your final patch is identical to the one in mozilla-1.0.0-9 which is incomplete.
It still doesn't address the missing .cfg files. I know it might not directly
relate to this bug, but it is related.

Comment 18

[hacker formerly known as [e-mail]]

The .cfg files are private NSPR cfg files that aren't meant to be installed on
the system.  The only reason they were installed into $(DIST) in the first place
was so that we could cross-compile.
 

Comment 19

[Christopher Blizzard (:blizzard)]

Attachment: more final patch

Fix problems with nsBuildID.h being regenerated during make install.

Comment 20

[hacker formerly known as [e-mail]]

Comment on attachment 87378 [details] [diff] [review]
more final patch

r=cls

Comment 21

[hacker formerly known as [e-mail]]

Patch has been checked in on the mozilla trunk, mozilla 1.0 branch & the nspr trunk.

Comment 22

[Asa Dotzler [:asa]]

adding branch resolution keyword.