Closed Bug 1494845 Opened 7 years ago Closed 7 years ago

[wpt-sync] Sync PR 13250 - Reland: service worker: Add WPT tests for resultingClientId.

Categories

(Core :: DOM: Service Workers, enhancement, P4)

Product:
Core
Component:
DOM: Service Workers
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla64
Tracking Flags:
Tracking Status
firefox64 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 13250 into mozilla-central (this bug is closed when the sync is complete). PR: https://github.com/web-platform-tests/wpt/pull/13250 Details from upstream follow. Matt Falkenhagen <falken@chromium.org> wrote: > Reland: service worker: Add WPT tests for resultingClientId. > > Reland of r592363, which was reverted due to timeouts. The timeout issue > should be fixed by r594723, which changed the mechanism of sending the > "last url" message from the navigated frame. > > Other revisions from the original patch: > - Removed the unused expected_tags parameter from the default > variant test function. > - Removed the dummy message resolver for "last url" from > client_variant_test, which is no longer needed after the change > mentioned above. > - Fixed a bug in redirect-worker.js's getClients(), where > we returned instead of continued to the next iteration. > > Original commit description: > > This adds a ?client variant to navigation-redirect.https.html, which > > does a lot of redirect tests. This tests the following: > > - resultingClientId is the id of the client, if one was created via > > that request. > > - get(resultingClientId) for requests that did not create a client > > resolves with undefined. > > - resultingClientId is reset on cross-origin redirects. > > - Client.url is the creation URL. > > > > Bug: 778497 > > Change-Id: I08387e96a97df4656d800637862b67b7c8466e14 > > Reviewed-on: https://chromium-review.googlesource.com/1206054 > > Reviewed-by: Makoto Shimazu \<shimazu@chromium.org> > > Commit-Queue: Matt Falkenhagen \<falken@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#592363} > > Bug: 778497 > Change-Id: I770f98cef7618c89c1b54245bc89a9c53a19bd5c > > Reviewed-on: https://chromium-review.googlesource.com/1250306 > WPT-Export-Revision: 774720428d1a2989942300a0b7e9267581a773b2
PR 13250 applied with additional changes from upstream: 8a07843f73f18ca87c2751938eb1f6f393aa7875
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Component: web-platform-tests → DOM: Service Workers
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Ran 3 tests and 96 subtests OK : 3 PASS : 60 FAIL : 36 New tests that have failures or other problems: /service-workers/service-worker/navigation-redirect.https.html?client No location redirect response via Cache.: FAIL No location redirect response.: FAIL Normal redirect to other-origin scope.: FAIL Normal redirect to same-origin scope with a hash fragment.: FAIL Normal redirect to same-origin scope with different hash fragments.: FAIL Normal redirect to same-origin scope.: FAIL Redirect to other-origin in-scope with opaque redirect response which is passed through Cache.: FAIL Redirect to other-origin in-scope with opaque redirect response.: FAIL Redirect to other-origin out-scope with opaque redirect response which is passed through Cache.: FAIL Redirect to other-origin out-scope with opaque redirect response.: FAIL Redirect to same-origin other-scope with opaque redirect response which is passed through Cache.: FAIL Redirect to same-origin other-scope with opaque redirect response.: FAIL Redirect to same-origin out-scope with opaque redirect response which is passed through Cache.: FAIL Redirect to same-origin out-scope with opaque redirect response.: FAIL Redirect to same-origin same-scope with opaque redirect response which is passed through Cache.: FAIL Redirect to same-origin same-scope with opaque redirect response.: FAIL SW-fallbacked redirect to other-origin and back to same-origin.: FAIL SW-fallbacked redirect to other-origin in-scope.: FAIL SW-fallbacked redirect to other-origin out-scope.: FAIL SW-fallbacked redirect to same-origin other-scope.: FAIL SW-fallbacked redirect to same-origin out-scope.: FAIL SW-fallbacked redirect to same-origin same-scope with a hash fragment.: FAIL SW-fallbacked redirect to same-origin same-scope with different hash fragments.: FAIL SW-fallbacked redirect to same-origin same-scope.: FAIL SW-fetched redirect to other-origin in-scope.: FAIL SW-fetched redirect to other-origin out-scope.: FAIL SW-fetched redirect to same-origin other-scope.: FAIL SW-fetched redirect to same-origin out-scope.: FAIL SW-fetched redirect to same-origin same-scope.: FAIL SW-generated redirect to other-origin in-scope.: FAIL SW-generated redirect to other-origin out-scope.: FAIL SW-generated redirect to same-origin other-scope.: FAIL SW-generated redirect to same-origin out-scope with a hash fragment.: FAIL SW-generated redirect to same-origin out-scope with different hash fragments.: FAIL SW-generated redirect to same-origin out-scope.: FAIL SW-generated redirect to same-origin same-scope.: FAIL
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/96c83eef3a96 [wpt PR 13250] - Reland: service worker: Add WPT tests for resultingClientId., a=testonly https://hg.mozilla.org/integration/mozilla-inbound/rev/5f90d6f37479 [wpt PR 13250] - Update wpt metadata, a=testonly
https://hg.mozilla.org/mozilla-central/rev/96c83eef3a96 https://hg.mozilla.org/mozilla-central/rev/5f90d6f37479
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox64: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.