Closed Bug 1494889 Opened 6 years ago Closed 6 years ago

[wpt-sync] Sync PR 13254 - [css-contain] Layout|Size containment and baseline in flexbox|grid

Categories

(Core :: CSS Parsing and Computation, enhancement, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla64
Tracking Flags:
Tracking Status
firefox64 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream]) 

Sync web-platform-tests PR 13254 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/13254
Details from upstream follow.

Manuel Rego Casasnovas <rego@igalia.com> wrote:
>  [css-contain] Layout|Size containment and baseline in flexbox|grid
>  
>  In r591642 we updated the behavior so layout containment
>  suppress baseline alignment, while size containment does not.
>  However, we forgot about the special cases (flexbox and grid)
>  that have their own code for this, which are fixed in this patch.
>  
>  Regarding WPT tests, these changes will fix the following issue:
>  https://github.com/web-platform-tests/wpt/issues/13252
>  
>  BUG=882333
>  TEST=external/wpt/css/css-contain/contain-layout-button-001.html
>  TEST=external/wpt/css/css-contain/contain-layout-flexbox-001.html
>  TEST=external/wpt/css/css-contain/contain-layout-grid-001.html
>  TEST=external/wpt/css/css-contain/contain-size-button-001.html
>  TEST=external/wpt/css/css-contain/contain-size-flexbox-001.html
>  TEST=external/wpt/css/css-contain/contain-size-grid-001.html
>  
>  Change-Id: I5e437d7f82d07d2f6222416a1eb9a3b89cb44eca
>  Reviewed-on: https://chromium-review.googlesource.com/1250524
>  WPT-Export-Revision: edc08c63e155842ac016b1d85f39859079cd867d
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Ran 6 tests
PASS   : 1
FAIL   : 5

Existing tests that now have a worse result (e.g. they used to PASS and now FAIL):
/css/css-contain/contain-size-button-001.html: FAIL
/css/css-contain/contain-size-flexbox-001.html: FAIL

New tests that have failures or other problems:
/css/css-contain/contain-layout-button-001.html: FAIL
/css/css-contain/contain-layout-flexbox-001.html: FAIL
/css/css-contain/contain-layout-grid-001.html: FAIL
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8f0661c28e34
[wpt PR 13254] - [css-contain] Layout|Size containment and baseline in flexbox|grid, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/159e7ec90805
[wpt PR 13254] - Update wpt metadata, a=testonly
https://hg.mozilla.org/mozilla-central/rev/8f0661c28e34
https://hg.mozilla.org/mozilla-central/rev/159e7ec90805
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox64: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.