Closed Bug 1494893 Opened Last year Closed 11 months ago

Review CSS of Runtime page

Categories

(DevTools :: about:debugging, enhancement, P1)

enhancement

Tracking

(firefox65 fixed)

RESOLVED FIXED
Firefox 65
Tracking Status
firefox65 --- fixed

People

(Reporter: ladybenko, Assigned: daisuke)

References

Details

Attachments

(7 files)

- Polish CSS of the Runtime page (currently "This Firefox")
- Make sure that the styles conform to spec (like about:preferences)
Hi Victoria,

In "about:preferences" (and its common.css stylesheet), the width of the page is hardcoded to be always the same size - this means horizontal scrolling bars if the viewport cannot fit the page and sidebar (see https://d3kxowhw4s8amj.cloudfront.net/file/data/jmil67tonlmtalmq4gew/PHID-FILE-hoccvjnjklmosvpbikva/thisfirefox-after.mp4 )
Initially we made the pages to be "elastic", so if the viewport cannot fit the page, we reduce its width (see https://d3kxowhw4s8amj.cloudfront.net/file/data/4cng5bulzzuxlcathax4/PHID-FILE-xikbpak2yk7hi3rnniyh/thisfirefox-before.mp4).

We are wondering which behavior we should keep: a) keep the page width the same regardless viewport size; or b) make the page width smaller if the viewport cannot fit it.

Thanks!
Flags: needinfo?(victoria)
Hi Belén,

Yes, I see what you mean, the Preferences is pretty limited in responsiveness. I love the elastic solution you came up with! Thanks for this attention to usability.
Flags: needinfo?(victoria)
Thanks Victoria! Will make the pages elastic PS: It was actually Daisuke who raised the issue – so kudos to him!
For the record, after Bug 1490954, the Manifest URL normally displayed for addons is completely hidden. The 664px width is too narrow for the current layout. If this will not be fixed by this bug can you please file another one.
Assignee: nobody → dakatsuka
Status: NEW → ASSIGNED
Priority: P2 → P1
Pushed by dakatsuka@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2e7f76844ef4
Refactoring RuntimeInfo component. r=ladybenko
https://hg.mozilla.org/integration/autoland/rev/f02f0e155c64
Refactoring DebugTargetPane component. r=ladybenko
https://hg.mozilla.org/integration/autoland/rev/fb7186abf1b1
Refactoring DebugTargetList component. r=ladybenko
https://hg.mozilla.org/integration/autoland/rev/fc8c2b63b513
Refactoring DebugTargetItem component. r=ladybenko
https://hg.mozilla.org/integration/autoland/rev/dea610ba60a5
Refactoring ExtensionDetail component. r=ladybenko
https://hg.mozilla.org/integration/autoland/rev/0fe63c4978cd
Referctoring for WorkerDetail component. r=ladybenko
https://hg.mozilla.org/integration/autoland/rev/cfb6077ee31b
Introduce elastic feature to RuntimaPage. r=ladybenko
You need to log in before you can comment on or make changes to this bug.