Closed Bug 1494894 Opened Last year Closed 11 months ago

Review CSS of sidebar

Categories

(DevTools :: about:debugging, enhancement, P1)

enhancement

Tracking

(firefox65 fixed)

RESOLVED FIXED
Firefox 65
Tracking Status
firefox65 --- fixed

People

(Reporter: ladybenko, Assigned: jdescottes)

References

Details

Attachments

(8 files, 1 obsolete file)

- Polish CSS of the Sidebar
- Make sure that the styles conform to spec (like about:preferences)
Currently, non-selectable sidebar items have opacity: 0.5 set on the whole container. Consequently the connect button looks disabled.

I don't think it's worth filing a dedicated bug for it, so I am just commenting here.
Attached image image.png
first button is the current design, second button is without applying opacity: 0.5 on the button.
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Priority: P2 → P1
network location devices have a smaller height and the icon is smaller so it looks off.
Not related to Sidebar CSS fixes but I don't think it is worth its own
bug.
Depends on D9652

This allows the Connect button to no longer look disabled. However we could maybe mutualize
colors a bit more, either with a --color-disabled variable or with a class.
Depends on D9654

This padding is already set on SidebarItem so I think we can skip it here?
Attachment #9019664 - Attachment is obsolete: true
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2812a46d115d
sidebar CSS: use color instead of opacity for unselectable items;r=ladybenko
https://hg.mozilla.org/integration/autoland/rev/385fec55c19a
sidebar CSS: use constant sidebar item height;r=ladybenko
https://hg.mozilla.org/integration/autoland/rev/b695f0e14d61
sidebar CSS: remove duplicated padding on FixedSidebarItem;r=ladybenko
https://hg.mozilla.org/integration/autoland/rev/37b458c3e91e
sidebar CSS: keep USB and network runtime icons aligned;r=ladybenko
You need to log in before you can comment on or make changes to this bug.