1494925 - Operator icons in the participants list are stretched

Status: RESOLVED FIXED

(Thunderbird :: Instant Messaging, enhancement)

Description

[Richard Marti (:Paenglab)]

This seems to be a fallout of bug 1475817. The operator icons in the participants list are too tall.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: chat-icons.patch

Fixed the icons through adding align="center".

I also found that we use aItem.firstChild.removeAttribute("image"); but we never set "image" but "src". So I think aItem.firstChild.removeAttribute("src"); is correct.

Comment 2

[Jorg K (CEST = GMT+2)]

What's an "operator icon"? The star left to the name in the participants? On Windows that's 14px high in 60 ESR and on trunk, so I can't see anything too high. Maybe they are squashed a little horizontally.

What I can see hover is that if you hover a participant that's idle, the orange clock is missing from the popup. Is that another bug or can we extend the scope here a bit?

Comment 3

[Jorg K (CEST = GMT+2)]

Comment on attachment 9012830 [details] [diff] [review]
chat-icons.patch

Yes, I guess the star doesn't look squashy with the patch.

Looks like the reviewer was sleeping here :-(
https://hg.mozilla.org/comm-central/rev/02051239a1bd#l3.31

It would still be good to fix the idle icon. And the away icon is also missing.

Comment 4

[Richard Marti (:Paenglab)]

(In reply to Jorg K (GMT+2) from comment #2)
> 
> What I can see hover is that if you hover a participant that's idle, the
> orange clock is missing from the popup. Is that another bug or can we extend
> the scope here a bit?

That should go into a new bug.

Comment 5

[Richard Marti (:Paenglab)]

Comment on attachment 9012830 [details] [diff] [review]
chat-icons.patch

Bug 1475817 has target TB 63. Do we want to fix it there too?

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/2727ba9a62aa
Fix the squashed operator icons in chat. r=jorgk

Comment 7

[Jorg K (CEST = GMT+2)]

Beta (TB 63):
https://hg.mozilla.org/releases/comm-beta/rev/d3251124cde1782106ac1a46f6e27bd698640c6d