Closed Bug 1494925 Opened Last year Closed Last year

Operator icons in the participants list are stretched

Categories

(Thunderbird :: Instant Messaging, enhancement)

enhancement
Not set

Tracking

(thunderbird63 fixed, thunderbird64 fixed)

RESOLVED FIXED
Thunderbird 64.0
Tracking Status
thunderbird63 --- fixed
thunderbird64 --- fixed

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(1 file)

This seems to be a fallout of bug 1475817. The operator icons in the participants list are too tall.
Attached patch chat-icons.patchSplinter Review
Fixed the icons through adding align="center".

I also found that we use aItem.firstChild.removeAttribute("image"); but we never set "image" but "src". So I think aItem.firstChild.removeAttribute("src"); is correct.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9012830 - Flags: review?(jorgk)
What's an "operator icon"? The star left to the name in the participants? On Windows that's 14px high in 60 ESR and on trunk, so I can't see anything too high. Maybe they are squashed a little horizontally.

What I can see hover is that if you hover a participant that's idle, the orange clock is missing from the popup. Is that another bug or can we extend the scope here a bit?
Comment on attachment 9012830 [details] [diff] [review]
chat-icons.patch

Yes, I guess the star doesn't look squashy with the patch.

Looks like the reviewer was sleeping here :-(
https://hg.mozilla.org/comm-central/rev/02051239a1bd#l3.31

It would still be good to fix the idle icon. And the away icon is also missing.
Attachment #9012830 - Flags: review?(jorgk) → review+
(In reply to Jorg K (GMT+2) from comment #2)
> 
> What I can see hover is that if you hover a participant that's idle, the
> orange clock is missing from the popup. Is that another bug or can we extend
> the scope here a bit?

That should go into a new bug.
Keywords: checkin-needed
Comment on attachment 9012830 [details] [diff] [review]
chat-icons.patch

Bug 1475817 has target TB 63. Do we want to fix it there too?
Attachment #9012830 - Flags: approval-mozilla-beta?
Attachment #9012830 - Flags: approval-mozilla-beta? → approval-comm-beta+
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/2727ba9a62aa
Fix the squashed operator icons in chat. r=jorgk
Status: ASSIGNED → RESOLVED
Closed: Last year
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 64.0
You need to log in before you can comment on or make changes to this bug.