Closed
Bug 1494953
Opened 6 years ago
Closed 6 years ago
Make nsFrame::DidSetComputedStyle initiate resource document filter loads
Categories
(Core :: SVG, enhancement, P3)
Core
SVG
Tracking
()
RESOLVED
FIXED
mozilla64
Tracking | Status | |
---|---|---|
firefox64 | --- | fixed |
People
(Reporter: jwatt, Assigned: jwatt)
References
Details
Attachments
(2 files)
I introduced some issues while separating filter handling from EffectProperties in bug 1494355.
Assignee | ||
Comment 1•6 years ago
|
||
Okay, it looks like the only thing I broke was nsFrame::DidSetComputedStyle initiating resource document loads when an element references filters in resource documents. I'll start with a preliminary patch to rename some of the functions that were causing me some confusion.
Summary: Fix some issues introduced while separating filter handling from EffectProperties (bug 1494355) → Make nsFrame::DidSetComputedStyle initiate resource document filter loads
Assignee | ||
Comment 2•6 years ago
|
||
The lack of clarity over which functions initiate observing and which don't is a headache since it makes it hard to reason about what's going on. This rename makes it explicit in the function names.
Assignee | ||
Comment 3•6 years ago
|
||
In bug 1488300 xidorn make us kick off loading of masks/filters/clipPaths in resource documents when the style context is set so that the 'load' event will be blocked until they load. I missed that in 5177bb8cb2ce (bug 1494355) where we stopped creating the SVGFilterObserverList in SVGObserverUtils::GetEffectProperties since I missed that creating that object looks up the target element (without observing it), which triggers loading of external resources as necessary. Depends on D7187
Comment 4•6 years ago
|
||
Comment on attachment 9012920 [details] Bug 1494953 p1. Rename lots of SVGObserverUtils functions. r?longsonr Robert Longson [:longsonr] has approved the revision.
Attachment #9012920 -
Flags: review+
Comment 5•6 years ago
|
||
Comment on attachment 9012921 [details] Bug 1494953 p2. Make nsFrame::DidSetComputedStyle initiate external filter loads. r?longsonr Robert Longson [:longsonr] has approved the revision.
Attachment #9012921 -
Flags: review+
Pushed by jwatt@jwatt.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/31015657ecfb p1. Rename lots of SVGObserverUtils functions. r=longsonr https://hg.mozilla.org/integration/mozilla-inbound/rev/d3f710de2349 p2. Make nsFrame::DidSetComputedStyle initiate external filter loads. r=longsonr
Comment 7•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/31015657ecfb https://hg.mozilla.org/mozilla-central/rev/d3f710de2349
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in
before you can comment on or make changes to this bug.
Description
•