1494956 - [socket-process] mozilla::net::SocketProcessImpl::Init - ERROR: AddressSanitizer: SEGV on unknown address 0x000000000000

Status: RESOLVED FIXED

(Core :: Networking, defect, P3)

Description

[Honza Bambas (:mayhemer)]

hits on push to larch, Linux x64 asan Mochitests with e10s test-linux64-asan/opt-mochitest-browser-chrome-e10s-16 M-e10s(bc16).

https://hg.mozilla.org/projects/larch/annotate/55a5826ef371/netwerk/ipc/SocketProcessImpl.cpp#l63

https://treeherder.mozilla.org/logviewer.html#?job_id=202210391&repo=larch&lineNumber=1391

[task 2018-09-28T12:45:14.516Z] 12:45:14    ERROR - GECKO(1072) | ==1093==ERROR: AddressSanitizer: SEGV on unknown address 0x000000000000 (pc 0x556085d82db0 bp 0x7fffcc2477b0 sp 0x7fffcc246f30 T0)
[task 2018-09-28T12:45:14.517Z] 12:45:14     INFO - GECKO(1072) | ==1093==The signal is caused by a READ memory access.
[task 2018-09-28T12:45:14.518Z] 12:45:14     INFO - GECKO(1072) | ==1093==Hint: address points to the zero page.
[task 2018-09-28T12:45:14.781Z] 12:45:14     INFO - GECKO(1072) |     #0 0x556085d82daf in __interceptor_strcmp /builds/worker/workspace/moz-toolchain/src/llvm/projects/compiler-rt/lib/asan/../sanitizer_common/sanitizer_common_interceptors.inc
[task 2018-09-28T12:45:15.438Z] 12:45:15     INFO - GECKO(1072) |     #1 0x7fc4096bb7b0 in mozilla::net::SocketProcessImpl::Init(int, char**) /builds/worker/workspace/build/src/netwerk/ipc/SocketProcessImpl.cpp:63:9
[task 2018-09-28T12:45:15.438Z] 12:45:15     INFO - GECKO(1072) |     #2 0x7fc4144dd1fc in XRE_InitChildProcess(int, char**, XREChildData const*) /builds/worker/workspace/build/src/toolkit/xre/nsEmbedFunctions.cpp:745:21
[task 2018-09-28T12:45:15.438Z] 12:45:15     INFO - GECKO(1072) |     #3 0x556085e406f4 in content_process_main /builds/worker/workspace/build/src/browser/app/../../ipc/contentproc/plugin-container.cpp:50:30
[task 2018-09-28T12:45:15.439Z] 12:45:15     INFO - GECKO(1072) |     #4 0x556085e406f4 in main /builds/worker/workspace/build/src/browser/app/nsBrowserApp.cpp:287
[task 2018-09-28T12:45:15.519Z] 12:45:15     INFO - GECKO(1072) |     #5 0x7fc42775982f in __libc_start_main /build/glibc-Cl5G7W/glibc-2.23/csu/../csu/libc-start.c:291
[task 2018-09-28T12:45:15.520Z] 12:45:15     INFO - GECKO(1072) |     #6 0x556085d6fae8 in _start (/builds/worker/workspace/build/application/firefox/firefox+0x28ae8)
[task 2018-09-28T12:45:15.521Z] 12:45:15     INFO - GECKO(1072) | AddressSanitizer can not provide additional info.
[task 2018-09-28T12:45:15.522Z] 12:45:15     INFO - GECKO(1072) | SUMMARY: AddressSanitizer: SEGV /builds/worker/workspace/moz-toolchain/src/llvm/projects/compiler-rt/lib/asan/../sanitizer_common/sanitizer_common_interceptors.inc in __interceptor_strcmp
[task 2018-09-28T12:45:15.523Z] 12:45:15     INFO - GECKO(1072) | ==1093==ABORTING

Comment 1

[Kershaw Chang [:kershaw]]

Attachment: Bug 1494956 - Add null check on aArgv

Simply add a null check, since |aArgv[i]| could be null.

Comment 2

[Honza Bambas (:mayhemer)]

Comment on attachment 9013326 [details]
Bug 1494956 - Add null check on aArgv

Honza Bambas (:mayhemer) has approved the revision.

Comment 3

[Honza Bambas (:mayhemer)]

Please land the patch on larch (I have WIP patches in the tree right now and can't do it)

Comment 4

[Kershaw Chang [:kershaw]]

(In reply to Honza Bambas (:mayhemer) from comment #3)
> Please land the patch on larch (I have WIP patches in the tree right now and
> can't do it)

Done.

Comment 5

[Junior [inactive]]

https://hg.mozilla.org/projects/larch/rev/2b5d6f5f5759