Closed
Bug 1494992
Opened 6 years ago
Closed 6 years ago
Record reference count changes for nsJARInputThunk
Categories
(Core Graveyard :: Web Replay, enhancement)
Core Graveyard
Web Replay
Tracking
(firefox64 fixed)
RESOLVED
FIXED
mozilla64
| Tracking | Status | |
|---|---|---|
| firefox64 | --- | fixed |
People
(Reporter: bhackett1024, Assigned: bhackett1024)
Details
Attachments
(1 file)
|
666 bytes,
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
nsJARInputThunk has a non-trivial destructor and from the crash below (reported by :jlast) it looks like the thread which destroys it can vary between recording and replaying if its reference count changes are not recorded. We've also had similar issues with other stream classes, e.g. nsPipeInputStream. https://crash-stats.mozilla.com/report/index/45b37f5c-a4a3-4eeb-abd0-0f16e0180928
Attachment #9012897 -
Flags: review?(nfroyd)
|
||
Updated•6 years ago
|
Attachment #9012897 -
Flags: review?(nfroyd) → review+
Pushed by bhackett@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/cde062deae16 Record reference count changes for nsJARInputThunk, r=froydnj.
|
||
Comment 2•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/cde062deae16
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
|
||
Updated•4 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•