1494994 - Crash in mozilla::recordreplay::RR_CGBitmapContextCreateWithData

Status: RESOLVED FIXED

(Core Graveyard :: Web Replay, defect)

Description

[Marcia Knous [:marcia]]

This bug was filed from the Socorro interface and is
report bp-327a44be-6831-4137-a242-3cd490180927.
=============================================================

Although this appears to be a single installation crashing twice, I thought it was interesting since it also had webrender stuff in the stack.

Top 10 frames of crashing thread:

0 XUL mozilla::recordreplay::RR_CGBitmapContextCreateWithData toolkit/recordreplay/ProcessRedirectDarwin.cpp:2195
1 libate.dylib EncodeASTC_4x4_RGBA_SSE4_1 
2 XUL webrender::platform::macos::font::FontContext::new third_party/rust/core-graphics/src/context.rs:97
3 XUL webrender::renderer::Renderer::new gfx/webrender/src/glyph_rasterizer/mod.rs:560
4 XUL wr_window_new gfx/webrender_bindings/src/bindings.rs:975
5 XUL mozilla::wr::NewRenderer::Run gfx/webrender_bindings/WebRenderAPI.cpp:74
6 XUL mozilla::wr::RenderThread::RunEvent gfx/webrender_bindings/RenderThread.cpp:319
7 XUL mozilla::detail::RunnableMethodImpl<mozilla::wr::RenderThread*, void  xpcom/threads/nsThreadUtils.h:1178
8 XUL MessageLoop::DoWork ipc/chromium/src/base/message_loop.cc:451
9 XUL base::MessagePumpDefault::Run ipc/chromium/src/base/message_pump_default.cc:38

=============================================================

Comment 1

[Brian Hackett [Laid off!]]

Attachment: patch

The attached patch force-disables WebRender in recording/replaying processes.  For now we only support the basic compositor / rendering paths when recording/replaying.  This shouldn't affect any WebRender related IPC as WebRender will still be turned on in the middleman process, which is responsible for sending graphics rendered by the tab up to the UI process.

Comment 2

[Nicolas Silva [:nical]]

Comment on attachment 9015132 [details] [diff] [review]
patch

Review of attachment 9015132 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/thebes/gfxPlatform.cpp
@@ +791,5 @@
>          gfxVars::SetGREDirectory(nsString(path));
>        }
> +
> +      if (recordreplay::IsRecordingOrReplaying()) {
> +        gfxVars::SetUseWebRender(false);

I'd prefer this to be in gfxPlatform::InitWebRenderConfig .

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d85e5fb4421c
Disable WebRender when recording/replaying, r=nical.

Comment 4

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/d85e5fb4421c