Closed Bug 1495007 Opened 2 years ago Closed 2 years ago
Ensure that stdout is captured in executor subprocess
46 bytes, text/x-phabricator-request
|Details | Review|
On linux/osx this probably works due to the fork() multiprocessing model. On Windows that insanity doesn't happen so we end up with stdio not captured correctly which results in unstructred logging.
Multiprocessing on Linux and OSX implictly inherits the stdio handles into the subprocess. But on Windows that doesn't happen because it doesn't have fork() to abuse in the same way. So instead we need to ensure that we explicitly set up handling of stdio immediately after starting the executor subprocess to avoid gettin non-structured output.
Comment on attachment 9012916 [details] Bug 1495007 - Ensure that we capture stdio from executor subprocess Andreas Tolfsen ❲:ato❳ has approved the revision.
Attachment #9012916 - Flags: review+
Assignee: nobody → james
Status: NEW → ASSIGNED
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/d47b208203c8 Ensure that we capture stdio from executor subprocess r=ato
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/13278 for changes under testing/web-platform/tests
Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.
Upstream PR merged
Can't merge web-platform-tests PR due to failing upstream checks: Github PR https://github.com/web-platform-tests/wpt/pull/13278 * Taskcluster (pull_request) (https://tools.taskcluster.net/task-group-inspector/#/eOyASSbFQxiDi1-n7zWs6w)
You need to log in before you can comment on or make changes to this bug.