1495008 - Code referenced by code review bot shows incorrect line numbers

Status: RESOLVED INVALID

(Developer Infrastructure :: Source Code Analysis, enhancement)

Description

[Dave Townsend [:mossop]]

When the code review bot makes a comment it shows the line numbers of failing code. They don't seem right.

For example, here is a comment that the bot found: https://phabricator.services.mozilla.com/D2027#163553

Here is the mail I received:

INLINE COMMENTS
nsAppRunner.cpp:2591
                if (NS_SUCCEEDED(rv)) {
                  fprintf(fp, "user_pref(\"%s\", \"%s\");\n",
                          "startup.homepage_welcome_url.additional",
Warning: Statement should be inside braces [clang-tidy: readability-braces-around-statements]

if (NS_FAILED(rv))
                  ^
                   {

The code in the email shown for line 2591 is the code at that line but isn't the code that code review bot is complaining about. I have no idea which line the failure is actually for since that code appears multiple times throughout the file (none added by me!)

A second example: https://phabricator.services.mozilla.com/D6548#163547

References line 2672 as failing. The email I got showed the correct code for line 2672. The actual code it was complaining about was at line 2630.

Comment 1

[Steven MacLeod [:smacleod]]

:marco, can you triage this into the proper component? I'm not sure what you're using to track bugs like this.

Comment 2

[Marco Castelluccio [:marco]]

Thanks, we are using GitHub to track these issues. I've filed an issue for this: https://github.com/mozilla/release-services/issues/1564.