Account for tab warming and multiple "active" tabs when adjusting process priority

RESOLVED FIXED in Firefox 64

Status

()

enhancement
RESOLVED FIXED
7 months ago
7 months ago

People

(Reporter: dthayer, Assigned: dthayer)

Tracking

unspecified
mozilla64
Points:
---

Firefox Tracking Flags

(firefox64 fixed)

Details

(Whiteboard: [fxperf:p1])

Attachments

(1 attachment)

(Assignee)

Description

7 months ago
When we switch tabs, we adjust the process priority at the end of SetDocShellIsActive. We should really adjust it in SetRenderLayers to account for tab warming.

Additionally, when a tab is actually selected it seems like we should "cool off" the visible tab, decreasing its priority since it's about to be hidden.
(Assignee)

Comment 1

7 months ago
Taking this real quick since I think it's fairly simple.
Assignee: nobody → dothayer
Status: NEW → ASSIGNED
Whiteboard: [fxperf:p1]
(Assignee)

Comment 2

7 months ago
Our current prioritization mechanism doesn't account for tab
warming, or for the fact that the current tab should be
deprioritized. This corrects that.
Comment on attachment 9012958 [details]
Bug 1495032 - Proactively adjust tab priority on switch r=mconley

Mike Conley (:mconley) (:⚙️) has approved the revision.
Attachment #9012958 - Flags: review+

Comment 4

7 months ago
Pushed by dothayer@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bcdbc281a48d
Proactively adjust tab priority on switch r=mconley

Comment 5

7 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/bcdbc281a48d
Status: ASSIGNED → RESOLVED
Last Resolved: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.