Closed Bug 1495101 Opened 2 years ago Closed 2 years ago

De-RDF subscribe (follow-up to bug 457333)

Categories

(MailNews Core :: Backend, enhancement)

enhancement
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 64.0

People

(Reporter: aceman, Assigned: aceman)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #457333 +++

This bug is to remove remaining traces of RDF the subscribe dialog, which are already unused thanks to the re-implementation of the subscribe tree without RDF in bug 457333.
Ben, please take note.
Attached patch 1495101.patchSplinter Review
This removes the unused RDF backend (datasource) in subscribableServer.

It may be used in Seamonkey, but I think they also want to migrate to the new subscribe dialog we implemented (if they haven't already).

This renames the method getChildren to getChildURIs per Jorg's suggestion because it no longer returns the node objects objects (nsIRDFResource), but just URIs of the nodes.

The method is not used in base code, but may be useful for addons and I think also for other bugs/requests.

Try run:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=311ebb00b6633948e9a497a4cbe4196b5034c239
Attachment #9013035 - Flags: review?(jorgk)
Attachment #9013035 - Flags: feedback?(frgrahl)
BenC, this is just code that you can safely ignore in bug 453908.
Comment on attachment 9013035 [details] [diff] [review]
1495101.patch

Review of attachment 9013035 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, this is great. It was very late and you pointed me to a different try run ;-) - Plus, renaming the function and changing the test never had a try run. I'll check it locally before landing and also fix the indentation.

Sorry, FRG, I need a patch to land, so make this PLF (post-landing feedback) ;-)

::: mailnews/base/src/nsSubscribableServer.cpp
@@ +602,5 @@
>  }
>  
>  NS_IMETHODIMP
> +nsSubscribableServer::GetChildURIs(const nsACString &aPath,
> +                                  nsIUTF8StringEnumerator **aResult)

Nit: Bad indent.

::: mailnews/imap/src/nsImapIncomingServer.cpp
@@ +2649,5 @@
>  
>  
>  NS_IMETHODIMP
> +nsImapIncomingServer::GetChildURIs(const nsACString &aPath,
> +                                  nsIUTF8StringEnumerator **aResult)

And here.

::: mailnews/news/src/nsNntpIncomingServer.cpp
@@ +1330,5 @@
>  }
>  
>  NS_IMETHODIMP
> +nsNntpIncomingServer::GetChildURIs(const nsACString &aPath,
> +                                  nsIUTF8StringEnumerator **aResult)

And here.
Attachment #9013035 - Flags: review?(jorgk) → review+
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/d945c1cb9d91
remove interface nsISubscribeDataSource and related RDF code. r=jorgk
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Severity: minor → normal
Target Milestone: --- → Thunderbird 64.0
Summary: De-RDF subscribe → De-RDF subscribe (follow-up to bug 457333)
Comment on attachment 9013035 [details] [diff] [review]
1495101.patch

> Sorry, FRG, I need a patch to land, so make this PLF (post-landing feedback) ;-)

Generally ok with mailnews patches. Can't test 60+ mailnews because we are so broken and to unbreak we need to copy TB code anyway or reinvent the wheel. In any case slow progress in SeaMonkey land because not enough devs on board.

> mailnews/base/src/nsSubscribableServer.cpp

> +    if (NS_FAILED(rv))
> +      delete result;

NIT: If I add something I tend to always add curly braces around ifs these days.
Attachment #9013035 - Flags: feedback?(frgrahl) → feedback+
You need to log in before you can comment on or make changes to this bug.