1495112 - Idle and away icons missing in popup when hovering chat participants from RHS list

Status: RESOLVED FIXED

(Thunderbird :: Instant Messaging, enhancement)

Description

[Jorg K (CEST = GMT+2)]

+++ This bug was initially created as a clone of Bug #1494925 +++

As per bug 1494925 comment #2:

If you hover a participant on the RHS that's idle or away, the orange clock or red icon is missing from the popup.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: statusTypeIcon.patch

The icon state was in two different CSS files defined. One with single icons and one with a combined icon and using -moz-image-region. This ended that a single icon was used together with the -moz-image-region that pointed to a region outside the icon and thus showed then no icon.

Additionally I also removed more duplicate rules in imtooltip.css and removed the no more used icons. The removal of @import url("chrome://chat/skin/status.css"); in imtooltip.css is because it it not needed because the @import in chat.css is enough.

Comment 2

[Jorg K (CEST = GMT+2)]

Comment on attachment 9013084 [details] [diff] [review]
statusTypeIcon.patch

This works for me. You did quite some clean up and aligned the three platforms, all using another PNG for HDPI displays (1.1dppx). Nice.

BTW, as per your PM, I also see "available" when first hovering the participant before the complete tooltip popup is shown. That's already the case in TB 60.

Any backport to TB 63 beta here?

Comment 3

[Richard Marti (:Paenglab)]

Thanks. Yes, I flag it for beta.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f1d5e3172659
Reference only one PNG file for the status icons in chat. r=jorgk DONTBUILD

Comment 5

[Richard Marti (:Paenglab)]

Attachment: statusTypeIcon-beta.patch

It needs a special patch because beta has no tree theming.

Comment 6

[Jorg K (CEST = GMT+2)]

Comment on attachment 9013084 [details] [diff] [review]
statusTypeIcon.patch

Too quick, this needs a beta patch.

Comment 7

[Jorg K (CEST = GMT+2)]

Beta (TB 63):
https://hg.mozilla.org/releases/comm-beta/rev/fda20ce8b8568aa1422277a1c30e474a3531565e

Comment 8

[Richard Marti (:Paenglab)]

Attachment: 1495112-fixTypo.patch

Sorry, I made a error in converting a combined margin.

Comment 9

[Jorg K (CEST = GMT+2)]

Comment on attachment 9015454 [details] [diff] [review]
1495112-fixTypo.patch

No problem :-)

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/22c54a00f503
Follow-up: Fix declaration with too many attributes. r=jorgk DONTBUILD