Idle and away icons missing in popup when hovering chat participants from RHS list

RESOLVED FIXED in Thunderbird 64.0

Status

enhancement
RESOLVED FIXED
10 months ago
9 months ago

People

(Reporter: jorgk, Assigned: Paenglab)

Tracking

unspecified
Thunderbird 64.0

Thunderbird Tracking Flags

(thunderbird63 fixed, thunderbird64 fixed)

Details

Attachments

(3 attachments)

+++ This bug was initially created as a clone of Bug #1494925 +++

As per bug 1494925 comment #2:

If you hover a participant on the RHS that's idle or away, the orange clock or red icon is missing from the popup.
Summary: Operator icons in the participants list are stretched → Idle and away icons missing in popup when hovering chat participants from RHS list
The icon state was in two different CSS files defined. One with single icons and one with a combined icon and using -moz-image-region. This ended that a single icon was used together with the -moz-image-region that pointed to a region outside the icon and thus showed then no icon.

Additionally I also removed more duplicate rules in imtooltip.css and removed the no more used icons. The removal of @import url("chrome://chat/skin/status.css"); in imtooltip.css is because it it not needed because the @import in chat.css is enough.
Attachment #9013084 - Flags: review?(jorgk)
Comment on attachment 9013084 [details] [diff] [review]
statusTypeIcon.patch

This works for me. You did quite some clean up and aligned the three platforms, all using another PNG for HDPI displays (1.1dppx). Nice.

BTW, as per your PM, I also see "available" when first hovering the participant before the complete tooltip popup is shown. That's already the case in TB 60.

Any backport to TB 63 beta here?
Attachment #9013084 - Flags: review?(jorgk) → review+
Thanks. Yes, I flag it for beta.
Keywords: checkin-needed
Attachment #9013084 - Flags: approval-comm-beta+
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/f1d5e3172659
Reference only one PNG file for the status icons in chat. r=jorgk DONTBUILD
Status: ASSIGNED → RESOLVED
Closed: 10 months ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 64.0
It needs a special patch because beta has no tree theming.
Attachment #9013108 - Flags: approval-comm-beta?
Comment on attachment 9013084 [details] [diff] [review]
statusTypeIcon.patch

Too quick, this needs a beta patch.
Attachment #9013084 - Flags: approval-comm-beta+
Attachment #9013108 - Flags: approval-comm-beta? → approval-comm-beta+
Sorry, I made a error in converting a combined margin.
Attachment #9015454 - Flags: review?(jorgk)
Attachment #9015454 - Flags: approval-comm-beta?
Comment on attachment 9015454 [details] [diff] [review]
1495112-fixTypo.patch

No problem :-)
Attachment #9015454 - Flags: review?(jorgk)
Attachment #9015454 - Flags: review+
Attachment #9015454 - Flags: approval-comm-beta?
Attachment #9015454 - Flags: approval-comm-beta+
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/22c54a00f503
Follow-up: Fix declaration with too many attributes. r=jorgk DONTBUILD
You need to log in before you can comment on or make changes to this bug.