Closed Bug 1495118 Opened Last year Closed 9 months ago

vixl_stats.csv gets created on invocation of ARM64 SpiderMonkey shell

Categories

(Core :: JavaScript Engine, enhancement)

ARM64
Linux
enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla66
Tracking Status
firefox64 --- wontfix
firefox65 --- wontfix
firefox66 --- fixed

People

(Reporter: gkw, Assigned: sstangl)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fuzzblocker])

Attachments

(1 file, 1 obsolete file)

Compile a js shell with --enable-simulator=arm64, run it then quit. vixl_stats.csv gets created in the current working directory.

This file should not be created.
Flags: needinfo?(sstangl)
Passing `nullptr` causes counter information to be redirected to stdout, which should be acceptable for simulator use cases.

@Gary -- you can apply this patch locally if you'd like.
Assignee: nobody → sstangl
Flags: needinfo?(sstangl)
Attachment #9013011 - Flags: review?(jitbugs)
Attachment #9013011 - Flags: review?(jitbugs) → review+
Keywords: checkin-needed
Gary requested a new patch that doesn't print to stdout either, so they can do differential testing on output.
Flags: needinfo?(sstangl)
Keywords: checkin-needed
Here's a better patch. It won't generate any output unless you specifically asked for it by setting the environment variable VIXL_STATS.
Attachment #9013011 - Attachment is obsolete: true
Flags: needinfo?(sstangl)
Attachment #9032039 - Flags: review?(nicolas.b.pierron)
Comment on attachment 9032039 [details] [diff] [review]
0001-Bug-1495118-Disable-vixl_stats.csv-unless-env-contai.patch

This works great. Thanks!
Attachment #9032039 - Flags: feedback+
Setting [fuzzblocker] because this blocks efficient fuzzing.
Whiteboard: [fuzzblocker]
Attachment #9032039 - Flags: review?(nicolas.b.pierron) → review+
Keywords: checkin-needed
Pushed by dluca@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/09a00e5dad4f
Disable vixl_stats.csv unless env contains VIXL_STATS. r=nbp
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/09a00e5dad4f
Status: NEW → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
Blocks: 1526993
You need to log in before you can comment on or make changes to this bug.