Closed Bug 1495118 Opened Last year Closed 9 months ago
_stats .csv gets created on invocation of ARM64 Spider Monkey shell
Compile a js shell with --enable-simulator=arm64, run it then quit. vixl_stats.csv gets created in the current working directory. This file should not be created.
Passing `nullptr` causes counter information to be redirected to stdout, which should be acceptable for simulator use cases. @Gary -- you can apply this patch locally if you'd like.
Assignee: nobody → sstangl
Attachment #9013011 - Flags: review?(jitbugs)
Attachment #9013011 - Flags: review?(jitbugs) → review+
Gary requested a new patch that doesn't print to stdout either, so they can do differential testing on output.
Here's a better patch. It won't generate any output unless you specifically asked for it by setting the environment variable VIXL_STATS.
Comment on attachment 9032039 [details] [diff] [review] 0001-Bug-1495118-Disable-vixl_stats.csv-unless-env-contai.patch This works great. Thanks!
Attachment #9032039 - Flags: feedback+
Setting [fuzzblocker] because this blocks efficient fuzzing.
Attachment #9032039 - Flags: review?(nicolas.b.pierron) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/09a00e5dad4f Disable vixl_stats.csv unless env contains VIXL_STATS. r=nbp
You need to log in before you can comment on or make changes to this bug.