1495118 - vixl_stats.csv gets created on invocation of ARM64 SpiderMonkey shell

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement)

Description

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Compile a js shell with --enable-simulator=arm64, run it then quit. vixl_stats.csv gets created in the current working directory.

This file should not be created.

Comment 1

[Sean Stangl [:sstangl]]

Attachment: 0001-Bug-1495118-ARM64-Simulator-should-not-create-a-CSV-.patch

Passing `nullptr` causes counter information to be redirected to stdout, which should be acceptable for simulator use cases.

@Gary -- you can apply this patch locally if you'd like.

Comment 2

[Sean Stangl [:sstangl]]

Gary requested a new patch that doesn't print to stdout either, so they can do differential testing on output.

Comment 3

[Sean Stangl [:sstangl]]

Attachment: 0001-Bug-1495118-Disable-vixl_stats.csv-unless-env-contai.patch

Here's a better patch. It won't generate any output unless you specifically asked for it by setting the environment variable VIXL_STATS.

Comment 4

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Comment on attachment 9032039 [details] [diff] [review]
0001-Bug-1495118-Disable-vixl_stats.csv-unless-env-contai.patch

This works great. Thanks!

Comment 5

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Setting [fuzzblocker] because this blocks efficient fuzzing.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/09a00e5dad4f
Disable vixl_stats.csv unless env contains VIXL_STATS. r=nbp

Comment 7

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/09a00e5dad4f