1495212 - after uninstall with 'Tell Mozilla why you uninstalled Firefox' set, Internet Explorer opened but no survey page (Windows 8.1)

Status: VERIFIED FIXED

(Firefox :: Installer, defect, P1)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Windows 8.1, latest Nightly 64-bit in German from http://ftp.mozilla.org/pub/firefox/nightly/2018/09/2018-09-29-10-05-56-mozilla-central-l10n/

After I uninstalled with the checkbox 'Tell Mozilla why you uninstalled Nightly' set, Internet Explorer opened but no survey page.

Steps to reproduce:
1. Install Firefox.
2. Go into the installation folder and there into "uninstall".
3. Run helper.exe
4. Set the checkbox to provide feedback why Nightly gets uninstalled.
5. Finish the uninstall process.

Actual result:
Internet Explorer opens but not survey page.

Expected result:
Survey page opened.

Comment 1

[Molly Howell (she/her) (mostly inactive)]

Do you mean that IE opened with no URL in its address bar (and/or opened its home page)? Or that the URL was there but the page didn't load?

Comment 2

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

IE opened with no URL in the address bar and showed the default home page with the tiles instead.

Comment 3

[Molly Howell (she/her) (mostly inactive)]

Okay, I've figured out what happened. This is a regression from bug 1494900 where I made a silly logic error and didn't catch it because I forgot about bug 1485057.

Comment 4

[Molly Howell (she/her) (mostly inactive)]

Attachment: Fix command line parameter checking in ExecInExplorer plugin

Comment 5

[Adam Gashlin (he/him) [:agashlin] (ex-moco)]

Comment on attachment 9013699 [details] [diff] [review]
Fix command line parameter checking in ExecInExplorer plugin

Crud, sorry for missing that reversed logic. Best to be using the error return anyway.

Comment 6

[Molly Howell (she/her) (mostly inactive)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/505f6ee17c14

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

This has landed and got merged with a wrong bug number: https://hg.mozilla.org/mozilla-central/rev/505f6ee17c14

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a07aead3f220
Fix command line parameter checking in ExecInExplorer plugin. r=agashlin DONTBUILD

Comment 9

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/a07aead3f220

Comment 10

[(PTO May 7-12) Ryan VanderMeulen [:RyanVM]]

Tracking for 63 since it's a regression from another tracked bug.

Comment 11

[Pascal Chevrel:pascalc]

Matt, could you uplift this regression fix to beta please? Thanks

Comment 12

[Molly Howell (she/her) (mostly inactive)]

Comment on attachment 9013699 [details] [diff] [review]
Fix command line parameter checking in ExecInExplorer plugin

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: Bug 1448804

User impact if declined: Uninstall survey may not open on Windows 7 and 8 (Windows 10 isn't affected).

Is this code covered by automated tests?: No

Has the fix been verified in Nightly?: Yes

Needs manual test from QE?: Yes

If yes, steps to reproduce: Uninstall a build of Firefox with this patch, check the uninstall survey box at the end of the uninstaller, and verify that the survey page opens correctly in Internet Explorer (or Edge on Windows 10).

I've done this verification myself, but I was never able to reproduce bug 1494900.

List of other uplifts needed: Bug 1494900

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): The affected feature is low impact and self-contained and the code runs after the end of the uninstallation, so the uninstall process itself is not impacted.

String changes made/needed:

Comment 13

[Pascal Chevrel:pascalc]

Comment on attachment 9013699 [details] [diff] [review]
Fix command line parameter checking in ExecInExplorer plugin

Tracked P1 regression, uplift approved for 63 beta 13, thanks.

Comment 14

[(PTO May 7-12) Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/fc2af75c2aca

Comment 15

[Gyula Palko[:gpalko]]

Verified, that the issue is no longer reproducible on Nightly 64(20181009100040) and Beta 63b13 (20181008155858). The uninstall survey page is successfully displayed in Internet Explorer(Windows7,Windows8) and Edge(Windows10).